From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, Antoine Pelisse <apelisse@gmail.com>
Subject: Re: [PATCH 1/8] remote-bzr: fix export of utf-8 authors
Date: Wed, 28 Aug 2013 14:58:39 -0700 [thread overview]
Message-ID: <xmqq7gf58okw.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpqy57l4jcx.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 28 Aug 2013 23:05:02 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
>> <Matthieu.Moy@grenoble-inp.fr> wrote:
>>
>>>> + bzr log | grep "^committer: " > ../actual
>>>> + ) &&
>>>> +
>>>> + echo "committer: Grégoire <committer@example.com>" > expected &&
>>>
>>> Git's source code usually says >../actual and >expected, without space
>>> after '>'.
>>
>> Not that usually:
>>
>> % git grep ' > ' t/*.sh | wc -l
>> 1943
>
> Do I really need to quote the paragraph in CodingGuidelines?
Existing violations are not an excuse to make things worse by adding
more. I think with these comments we can expect a reroll coming,
and it should be trivial for any contributor to fix it while at it.
next prev parent reply other threads:[~2013-08-28 21:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 19:23 [PATCH 0/8] remote-{hg,bzr}: updates Felipe Contreras
2013-08-28 19:23 ` [PATCH 1/8] remote-bzr: fix export of utf-8 authors Felipe Contreras
2013-08-28 20:05 ` Matthieu Moy
2013-08-28 20:48 ` Felipe Contreras
2013-08-28 20:54 ` Antoine Pelisse
2013-08-28 21:21 ` Felipe Contreras
2013-08-28 21:38 ` Felipe Contreras
2013-08-28 21:05 ` Matthieu Moy
2013-08-28 21:21 ` Felipe Contreras
2013-08-28 21:58 ` Junio C Hamano [this message]
2013-08-28 22:25 ` Felipe Contreras
2013-08-29 21:24 ` Re* " Junio C Hamano
2013-08-29 21:25 ` Junio C Hamano
2013-09-01 4:09 ` Michael Haggerty
2013-08-29 21:28 ` Antoine Pelisse
2013-08-29 21:42 ` Junio C Hamano
2013-08-29 21:44 ` Junio C Hamano
2013-09-01 4:03 ` Michael Haggerty
2013-08-28 20:35 ` Eric Sunshine
2013-08-28 21:14 ` [PATCH v2] " Felipe Contreras
2013-08-28 19:23 ` [PATCH 2/8] remote-bzr: make bzr branches configurable per-repo Felipe Contreras
2013-08-28 19:23 ` [PATCH 3/8] remote-hg: fix test Felipe Contreras
2013-08-28 19:23 ` [PATCH 4/8] remote-hg: add missing &&s in the test Felipe Contreras
2013-08-28 19:23 ` [PATCH 5/8] remote-hg: improve basic test Felipe Contreras
2013-08-28 19:23 ` [PATCH 6/8] remote-helpers: trivial style fixes Felipe Contreras
2013-08-28 19:23 ` [PATCH 7/8] remote-helpers: cleanup more global variables Felipe Contreras
2013-08-28 19:23 ` [PATCH 8/8] remote-hg: support for notes Felipe Contreras
2013-08-29 18:45 ` Junio C Hamano
2013-08-29 21:50 ` [PATCH] " Felipe Contreras
2013-08-29 22:12 ` Junio C Hamano
2013-08-29 22:29 ` [PATCH v3] " Felipe Contreras
2013-08-29 22:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7gf58okw.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=apelisse@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.