All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Noam Cohen <noam@noam.me>
Cc: git@vger.kernel.org, "Teng Long" <dyroneteng@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH] ls-tree: do not quote %(path) with -z
Date: Wed, 18 Nov 2026 17:24:42 -0800	[thread overview]
Message-ID: <xmqq8q2p1ulh.fsf@gitster.g> (raw)
In-Reply-To: <CAJeEYUaJt49oz+Fq7qwWGyB9p=Hibdzd3113FBhbK1RDn3oHug@mail.gmail.com> (Noam Cohen's message of "Wed, 18 Nov 2026 18:45:42 -0500")

Noam Cohen <noam@noam.me> writes:

> We could avoid the filesystem and synthesize the tree with "git
> mktree" instead, which is what I had at first, but that made the
> test noticeably more complicated than a test_commit in the setup.

Yeah, that, with forced core.quotePath setting, was what I had in
mind.

But it is not a requirement to avoid stepping outside US-ASCII while
writing tests.  It is much better to have tests that use bytes from
outside US-ASCII than not having at all.  It is just that it would
be nicer if we do not have to worry about platform anomalies that
cannot store characters outside US-ASCII range.



  reply	other threads:[~2026-11-19  1:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 23:04 [PATCH] ls-tree: do not quote %(path) with -z Noam Cohen via B4 Relay
2026-11-18 23:04 ` Noam Cohen
2026-11-18 23:20 ` Junio C Hamano
2026-11-18 23:45   ` Noam Cohen
2026-11-19  1:24     ` Junio C Hamano [this message]
2026-11-19  3:43 ` [PATCH v2] " Noam Cohen
2026-11-19  3:43   ` Noam Cohen via B4 Relay
2026-11-19 16:12   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8q2p1ulh.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=dyroneteng@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=noam@noam.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.