From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Srujith A Poojary via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Srujith A Poojary <poojarysrujith@gmail.com>
Subject: Re: [PATCH v2] diff-delta: use safe integer arithmetic
Date: Fri, 23 Oct 2026 11:49:37 -0700 [thread overview]
Message-ID: <xmqq8q3o5k1q.fsf@gitster.g> (raw)
In-Reply-To: <fe3d651a-d1af-47a7-9b7b-a4ff242ca303@gmail.com> (Phillip Wood's message of "Fri, 23 Oct 2026 16:15:47 +0100")
Phillip Wood <phillip.wood123@gmail.com> writes:
>> + memsize = st_add3(sizeof(*index),
>> + st_mult(sizeof(*packed_hash), hsize + 1),
>
> What are the bounds of hsize? Can adding one to it overflow? The
> alignment is off here as well, all the arguments to st_add3() should be
> aligned.
Very good question, and I think hsize is capped at 1^26 in a code
early in this function, which makes this safe. It needs to be
explained why it is safe in the log message, though.
next prev parent reply other threads:[~2026-10-23 18:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 3:56 [PATCH] [Outreachy PATCH] diff-delta: use safe integer arithmetic Srujith A Poojary via GitGitGadget
2026-10-23 5:04 ` Junio C Hamano
2026-10-23 5:29 ` Srujith Poojary
2026-10-23 15:30 ` Junio C Hamano
2026-10-23 16:56 ` Srujith Poojary
2026-10-23 18:45 ` Junio C Hamano
2026-10-23 5:56 ` [PATCH v2] " Srujith A Poojary via GitGitGadget
2026-10-23 15:15 ` Phillip Wood
2026-10-23 18:49 ` Junio C Hamano [this message]
2026-10-24 3:44 ` Srujith Poojary
2026-10-24 3:48 ` [PATCH v3] " Srujith A Poojary via GitGitGadget
2026-10-24 16:15 ` Junio C Hamano
2026-10-24 17:26 ` Srujith Poojary
2026-10-25 18:10 ` Junio C Hamano
2026-10-25 19:21 ` Srujith Poojary
2026-10-24 18:00 ` [PATCH v4] " Srujith A Poojary via GitGitGadget
2026-10-25 19:20 ` [PATCH v5] " Srujith A Poojary via GitGitGadget
2026-10-26 17:37 ` Junio C Hamano
2026-10-26 18:47 ` Srujith Poojary
2026-10-27 4:50 ` Srujith Poojary
2026-10-27 4:51 ` [PATCH v6] " Srujith A Poojary via GitGitGadget
2026-10-27 10:33 ` Pablo Sabater
2026-10-27 11:01 ` Srujith Poojary
2026-10-27 11:32 ` Pablo Sabater
2026-10-27 11:00 ` [PATCH v7] " Srujith A Poojary via GitGitGadget
2026-10-27 11:52 ` Pablo Sabater
2026-10-27 14:18 ` Srujith Poojary
2026-10-27 16:27 ` Junio C Hamano
2026-10-27 16:57 ` Srujith Poojary
2026-10-27 14:21 ` [PATCH v8] " Srujith A Poojary via GitGitGadget
2026-10-27 16:56 ` [PATCH v9] " Srujith A Poojary via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8q3o5k1q.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=poojarysrujith@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.