From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Elijah Newren <newren@gmail.com>,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [RFC PATCH 08/10] pack-objects: introduce '--stdin-packs=follow-reachable'
Date: Fri, 26 Jun 2026 19:09:32 -0700 [thread overview]
Message-ID: <xmqq8q8068f7.fsf@gitster.g> (raw)
In-Reply-To: <aj8cOhH6hGVZIFft@nand.local> (Taylor Blau's message of "Fri, 26 Jun 2026 20:41:30 -0400")
Taylor Blau <me@ttaylorr.com> writes:
>> > + if (packed_object_info(p, ofs, &oi) < 0)
>> > + return 0;
>> > + if (type != OBJ_COMMIT && type != OBJ_TAG)
>> > + return 0;
>>
>> We do not care about non commits, non tags.
>
> This should not be an &&, but rather an ||. We only want to handle
> objects which are either commits *or* tags via this function.
My comment above did not mean to say anything is wrong in the code;
I was just thinking aloud. We return for blob or tree because they
are not commit and they are not tag. If we say "||" then we return
for everybody, because anything that is a commit (failing the LHS of
the "||") cannot be a tag (satisfying the RHS of the "||").
next prev parent reply other threads:[~2026-06-27 2:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 19:02 [RFC PATCH 00/10] repack: combine '--geometric' and '--cruft' Taylor Blau
2026-06-26 19:02 ` [RFC PATCH 01/10] repack: unconditionally exclude non-kept packs Taylor Blau
2026-06-26 19:02 ` [RFC PATCH 02/10] repack: extract `locate_existing_pack()` helper Taylor Blau
2026-06-26 19:02 ` [RFC PATCH 03/10] repack: mark geometric progression of packs as retained Taylor Blau
2026-06-26 19:02 ` [RFC PATCH 04/10] repack: teach MIDX retention about geometric rollups Taylor Blau
2026-06-26 21:28 ` Junio C Hamano
2026-06-27 0:43 ` Taylor Blau
2026-06-26 19:02 ` [RFC PATCH 05/10] repack: delete geometric packs via existing_packs Taylor Blau
2026-06-26 19:02 ` [RFC PATCH 06/10] repack-geometry: drop unused redundant-pack removal Taylor Blau
2026-06-26 19:02 ` [RFC PATCH 07/10] pack-objects: extract `stdin_packs_add_all_pack_entries()` Taylor Blau
2026-06-26 19:02 ` [RFC PATCH 08/10] pack-objects: introduce '--stdin-packs=follow-reachable' Taylor Blau
2026-06-26 21:39 ` Junio C Hamano
2026-06-27 0:41 ` Taylor Blau
2026-06-27 2:09 ` Junio C Hamano [this message]
2026-06-27 2:26 ` Taylor Blau
2026-06-26 19:02 ` [RFC PATCH 09/10] pack-objects: support '--refs-snapshot' with 'follow-reachable' Taylor Blau
2026-06-26 19:02 ` [RFC PATCH 10/10] repack: support combining '--geometric' with '--cruft' Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8q8068f7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.