All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Chen Linxuan <me@black-desk.cn>
Cc: Chen Linxuan via B4 Relay <devnull+me.black-desk.cn@kernel.org>,
	git@vger.kernel.org,
	 Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
	 Patrick Steinhardt <ps@pks.im>,
	Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH v5 0/2] includeIf: add "worktree" condition for matching working tree path
Date: Mon, 25 May 2026 18:24:48 +0900	[thread overview]
Message-ID: <xmqq8q97et9b.fsf@gitster.g> (raw)
In-Reply-To: <CAC1kPDPbyxs-aTrAOi_PNTZF7EApG31iLYwm+Eddpeh2hT8a-w@mail.gmail.com> (Chen Linxuan's message of "Mon, 25 May 2026 17:00:23 +0800")

Chen Linxuan <me@black-desk.cn> writes:

> On Mon, May 25, 2026 at 3:31 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Chen Linxuan via B4 Relay <devnull+me.black-desk.cn@kernel.org>
>> writes:
>>
>> > Changes in v5:
>> > - Fix Windows CI failure: use `**` glob pattern instead of `/` in the
>> >   "worktree without repository" tests, since `/` as a path pattern is
>> >   Unix-specific and does not match Windows paths.
>>
>> Would it have worked if you used something like "[/\\].path",
>> instead of "/.path", to cover directory delimiters for both systems?
>>
>> I am not asking to make further changes.  I am trying to understand
>> what the extent of the problem was.
>
> The root cause is that on Windows,
> strbuf_realpath() returns paths with a drive letter prefix (e.g.
> D:/a/git/...), which does not start with /.

Ahh, OK, so the "Changes in v5" description was misleading.

This exchange suggests that the use of **/.path in the test deserves
some in-code comment to explain why we use such an unusual and loose
construct.

Thanks.


      reply	other threads:[~2026-05-25  9:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25  3:20 [PATCH v5 0/2] includeIf: add "worktree" condition for matching working tree path Chen Linxuan via B4 Relay
2026-05-25  3:20 ` Chen Linxuan
2026-05-25  3:20 ` [PATCH v5 1/2] config: refactor include_by_gitdir() into include_by_path() Chen Linxuan via B4 Relay
2026-05-25  3:20   ` Chen Linxuan
2026-05-25  3:20 ` [PATCH v5 2/2] config: add "worktree" and "worktree/i" includeIf conditions Chen Linxuan via B4 Relay
2026-05-25  3:20   ` Chen Linxuan
2026-05-25  7:31 ` [PATCH v5 0/2] includeIf: add "worktree" condition for matching working tree path Junio C Hamano
2026-05-25  9:00   ` Chen Linxuan
2026-05-25  9:24     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8q97et9b.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=devnull+me.black-desk.cn@kernel.org \
    --cc=git@vger.kernel.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=me@black-desk.cn \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.