From: Junio C Hamano <gitster@pobox.com>
To: Jialong Wang <jerrywang183@yahoo.com>
Cc: git@vger.kernel.org, karthik.188@gmail.com
Subject: Re: [GSoC PATCH v2] apply: report the location of corrupt patches
Date: Mon, 16 Mar 2026 13:12:09 -0700 [thread overview]
Message-ID: <xmqq8qbro7om.fsf@gitster.g> (raw)
In-Reply-To: <177368589341.86550.13587211475575359717.git-reply-v2-queue@yahoo.com> (Jialong Wang's message of "Mon, 16 Mar 2026 14:31:33 -0400")
Jialong Wang <jerrywang183@yahoo.com> writes:
> Thanks for the review.
>
> I sent a v3 after CI exposed two existing tests that still expected the
> old error format; v3 only updates those tests and does not change the
> main logic further.
>
> The other line-number-only error sites you pointed out, such as
> find_header() and parse_git_diff_header(), make sense to address in a
> follow-up patch.
I do not mind marking these as #leftoverbits; v3 looked great.
Thanks.
next prev parent reply other threads:[~2026-03-16 20:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260315231538.68586-1-jerrywang183.ref@yahoo.com>
2026-03-15 23:15 ` [GSoC PATCH] apply: report the location of corrupt patches Jialong Wang
2026-03-16 11:14 ` Karthik Nayak
2026-03-16 11:34 ` Jialong Wang
2026-03-16 11:34 ` [GSoC PATCH v2] " Jialong Wang
2026-03-16 18:19 ` Junio C Hamano
2026-03-16 16:21 ` [GSoC PATCH v3] " Jialong Wang
2026-03-17 16:23 ` [PATCH v4 0/3] apply: report input file for more parse errors Jialong Wang
2026-03-17 16:23 ` [PATCH v4 1/3] apply: report the location of corrupt patches Jialong Wang
2026-03-17 16:23 ` [PATCH v4 2/3] apply: report input location in header parsing errors Jialong Wang
2026-03-17 16:23 ` [PATCH v4 3/3] apply: report input location in binary and garbage patch errors Jialong Wang
[not found] ` <xmqq8qq6y4ql.fsf@gitster.g>
2026-03-16 18:31 ` [GSoC PATCH v2] apply: report the location of corrupt patches Jialong Wang
2026-03-16 20:12 ` Junio C Hamano [this message]
2026-03-16 19:58 ` [GSoC PATCH] apply: report input location in header parsing errors Jialong Wang
2026-03-16 19:58 ` Jialong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8qbro7om.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jerrywang183@yahoo.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.