All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: opensource@gregoirege.is
Cc: git@vger.kernel.org,  Ramsay Jones <ramsay@ramsayjones.plus.com>
Subject: Re: [PATCH v2] diff: --no-index should ignore the worktree
Date: Tue, 12 Aug 2025 08:07:42 -0700	[thread overview]
Message-ID: <xmqq8qjowpc1.fsf@gitster.g> (raw)
In-Reply-To: <B90C049E-677E-449A-A899-B6071F852298@gregoirege.is> (opensource@gregoirege.is's message of "Tue, 12 Aug 2025 23:37:39 +0900")

opensource@gregoirege.is writes:

> I don't know how the review process goes at this point as you took
> over the patch. The handling of the chdir failure in v2 LGTM. I ran
> the t*-diff*.sh tests again and tried a couple of commands, and
> everything seems to work.

Thanks.

  reply	other threads:[~2025-08-12 15:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-10  0:20 [PATCH v2] diff: --no-index should ignore the worktree Junio C Hamano
2025-08-12 14:37 ` opensource
2025-08-12 15:07   ` Junio C Hamano [this message]
2025-08-15 22:01 ` [PATCH] diff: simplify --no-index taking advantage of the fact that prefix==NULL Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8qjowpc1.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=opensource@gregoirege.is \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.