From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] curl: fix symbolic constant typechecks with curl_easy_setopt()
Date: Wed, 04 Jun 2025 14:25:09 -0700 [thread overview]
Message-ID: <xmqq8qm7b3nu.fsf@gitster.g> (raw)
In-Reply-To: <20250604205622.GC1510819@coredump.intra.peff.net> (Jeff King's message of "Wed, 4 Jun 2025 16:56:22 -0400")
Jeff King <peff@peff.net> writes:
> It seems kind of weird to me that curl doesn't define these constants as
> longs, since the point of them is to pass to curl_easy_setopt(). But in
> the curl documentation and examples, they clearly show casting them as
> part of the setopt calls. It may be that there is some reason not to
> push the type into the macro, like backwards compatibility. I didn't
> dig, as it doesn't really matter: we have to follow what existing curl
> versions ask for anyway.
Well reasoned, and I grew 100% with the above reasoning.
Thank you very much for putting these together. Will queue.
next prev parent reply other threads:[~2025-06-04 21:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 20:55 [PATCH 0/3] silencing warnings with curl 8.14 Jeff King
2025-06-04 20:55 ` [PATCH 1/3] curl: fix integer constant typechecks with curl_easy_setopt() Jeff King
2025-06-05 10:57 ` Johannes Schindelin
2025-06-05 16:04 ` Junio C Hamano
2025-06-05 22:49 ` Jeff King
2025-06-05 22:51 ` Jeff King
2025-06-05 23:13 ` Junio C Hamano
2025-06-05 22:47 ` Jeff King
2025-06-04 20:55 ` [PATCH 2/3] curl: fix integer variable " Jeff King
2025-06-04 20:56 ` [PATCH 3/3] curl: fix symbolic constant " Jeff King
2025-06-04 21:25 ` Junio C Hamano [this message]
2025-06-05 6:13 ` Daniel Stenberg
2025-06-05 7:25 ` Jeff King
2025-06-04 21:23 ` [PATCH 0/3] silencing warnings with curl 8.14 Collin Funk
2025-06-04 22:03 ` Ramsay Jones
2025-06-05 5:21 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8qm7b3nu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.