All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Toon Claes <toon@iotcl.com>,  git@vger.kernel.org
Subject: Re: [PATCH] builtin/clone: teach git-clone(1) the --ref= argument
Date: Fri, 27 Sep 2024 13:05:28 -0700	[thread overview]
Message-ID: <xmqq8qvcg8vr.fsf@gitster.g> (raw)
In-Reply-To: <ZvcHpd26te8TPacz@tapette.crustytoothpaste.net> (brian m. carlson's message of "Fri, 27 Sep 2024 19:29:41 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> I can't speak for what Toon intended here, but GitHub uses some
> references under `refs/pull` that are used for tracking pull requests.

Ah, that is an excellent example that can be used to strengthen the
motivation part of this commit.

    A user may want to clone only "refs/pull/$n/head" to take a
    peek, but unlike refs/heads/ and refs/tags/, for which the
    "--branch" option can be used, there is no good simple way to do
    so with "git clone".

would make a good intro paragraph for a proposed log message.

> So I think this is a generally useful feature, although I agree
> that perhaps the commit message might explain the benefits in a
> more concrete way for those who don't already understand the
> utility of the feature (such as our illustrious maintainer).

Yes, not seeing refs/pull/ without being told was slight lack of
imagination on my part, but it is a good idea to spell out the
motivation in concrete terms when we can.

Thanks.

  reply	other threads:[~2024-09-27 20:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27  8:54 [PATCH] builtin/clone: teach git-clone(1) the --ref= argument Toon Claes
2024-09-27 19:20 ` Junio C Hamano
2024-09-27 19:29   ` brian m. carlson
2024-09-27 20:05     ` Junio C Hamano [this message]
2024-09-27 20:10     ` Kristoffer Haugsbakk
  -- strict thread matches above, loose matches on Subject: below --
2024-07-22  8:07 [PATCH] fetch: use bundle URIs when having creationToken heuristic Toon Claes
2024-09-27  9:04 ` [PATCH] builtin/clone: teach git-clone(1) the --ref= argument Toon Claes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8qvcg8vr.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    --cc=toon@iotcl.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.