All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Sam James <sam@gentoo.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 0/2] diff: copies-harder support
Date: Thu, 16 May 2024 08:36:18 -0700	[thread overview]
Message-ID: <xmqq8r09u5u5.fsf@gitster.g> (raw)
In-Reply-To: <8734qihft5.fsf@gentoo.org> (Sam James's message of "Wed, 15 May 2024 23:27:02 +0100")

Sam James <sam@gentoo.org> writes:

> ping - let me know if I need to do anything different. Thanks!
>
>>>
>>>
>>>>  Documentation/config/diff.txt   |  8 +++++---
>>>>  Documentation/config/status.txt |  4 +++-
>>>>  diff.c                          | 14 +++++++++++---
>>>>  diff.h                          |  1 +
>>>>  diffcore-rename.c               |  6 ++++--
>>>>  merge-ort.c                     |  2 +-
>>>>  merge-recursive.c               |  2 +-
>>>>  7 files changed, 26 insertions(+), 11 deletions(-)

Copies-harder is supported from the command line already.  We do not
want a configuration variable for it.  diff.renames configuration
was already a mistake enough.  Let's not pile on a new mistake on an
old mistake that it is too late for us to take back.

Thanks.

  reply	other threads:[~2024-05-16 15:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 21:38 [PATCH v3 0/2] diff: copies-harder support Sam James
2024-03-11 21:38 ` [PATCH v3 1/2] diff: implement config.diff.renames=copies-harder Sam James
2024-03-11 21:38 ` [PATCH v3 2/2] diff: whitespace cleanup Sam James
2024-04-08 15:32 ` [PATCH v3 0/2] diff: copies-harder support Sam James
2024-04-16  2:42   ` Sam James
2024-05-15 22:27     ` Sam James
2024-05-16 15:36       ` Junio C Hamano [this message]
2024-05-17  3:38         ` Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8r09u5u5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.