All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Patrick Steinhardt <ps@pks.im>,  git@vger.kernel.org
Subject: Re: [PATCH v2] pack-bitmap: gracefully handle missing BTMP chunks
Date: Mon, 15 Apr 2024 16:46:44 -0700	[thread overview]
Message-ID: <xmqq8r1ei3yz.fsf@gitster.g> (raw)
In-Reply-To: <Zh2vhDraCnqw4YFL@nand.local> (Taylor Blau's message of "Mon, 15 Apr 2024 18:51:48 -0400")

Taylor Blau <me@ttaylorr.com> writes:

> On Mon, Apr 15, 2024 at 10:41:09AM -0700, Junio C Hamano wrote:
>> Patrick Steinhardt <ps@pks.im> writes:
>>
>> >> Helped-by: Taylor Blau <me@ttaylorr.com>
>> >> Signed-off-by: Patrick Steinhardt <ps@pks.im>
>> >
>> > Junio, it would be great if we could still land this fix in Git v2.45
>> > given that it is addressing a regression in Git v2.44. This of course
>> > assumes that the current version of this patch looks good to Taylor.
>>
>> Indeed.  It would be nice to see an acked by or something.
>>
>> Will queue, in the meantime.  Thanks for a ping.
>
> I took a look, and I think the patch is good. I have a couple of notes
> on the test that I would prefer to see addressed before merging it down,
> though.

Thanks.

  reply	other threads:[~2024-04-15 23:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-09  5:59 [PATCH] pack-bitmap: gracefully handle missing BTMP chunks Patrick Steinhardt
2024-04-10 15:02 ` Taylor Blau
2024-04-15  6:34   ` Patrick Steinhardt
2024-04-15 22:42     ` Taylor Blau
2024-04-15  6:41 ` [PATCH v2] " Patrick Steinhardt
2024-04-15  8:51   ` Patrick Steinhardt
2024-04-15 17:41     ` Junio C Hamano
2024-04-15 22:51       ` Taylor Blau
2024-04-15 23:46         ` Junio C Hamano [this message]
2024-04-15 22:51   ` Taylor Blau
2024-04-16  4:47     ` Patrick Steinhardt
2024-04-16  5:12       ` Jeff King
2024-04-16  5:14         ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8r1ei3yz.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.