All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: "Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com>,
	 Philippe Blain <levraiphilippeblain@gmail.com>
Subject: Re: [PATCH v2 0/5] completion: remove hardcoded config variable names
Date: Wed, 07 Feb 2024 14:08:07 -0800	[thread overview]
Message-ID: <xmqq8r3w53nc.fsf@gitster.g> (raw)
In-Reply-To: <pull.1660.v2.git.git.1706534881.gitgitgadget@gmail.com> (Philippe Blain via GitGitGadget's message of "Mon, 29 Jan 2024 13:27:56 +0000")

"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Changes since v1:
>
>  * Corrected my email in PATCH 2/5 (sorry for the noise)
>
> v1: This series removes hardcoded config variable names in the
> __git_complete_config_variable_name function, partly by adding a new mode to
> 'git help'. It also adds completion for 'submodule.*' config variables,
> which were previously missing.
>
> I think it makes sense to do that in the same series since it's closely
> related, and splitting it would result in textual conflicts between both
> series if one does not build on top of the other, but I'm open to other
> suggestions.
>
> Thanks,

Neither rounds of this series unfortunately got any review.
Comments from anybody interested in helping to improve completion
scripts?

Thanks.

  parent reply	other threads:[~2024-02-07 22:08 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-28 20:02 [PATCH 0/5] completion: remove hardcoded config variable names Philippe Blain via GitGitGadget
2024-01-28 20:02 ` [PATCH 1/5] completion: add space after config variable names also in Bash 3 Philippe Blain via GitGitGadget
2024-01-28 20:02 ` [PATCH 2/5] completion: complete 'submodule.*' config variables Philippe Blain via GitGitGadget
2024-01-28 20:02 ` [PATCH 3/5] completion: add and use __git_compute_first_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-01-28 20:02 ` [PATCH 4/5] builtin/help: add --config-all-for-completion Philippe Blain via GitGitGadget
2024-01-28 20:02 ` [PATCH 5/5] completion: add an use __git_compute_second_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-01-29 13:27 ` [PATCH v2 0/5] completion: remove hardcoded config variable names Philippe Blain via GitGitGadget
2024-01-29 13:27   ` [PATCH v2 1/5] completion: add space after config variable names also in Bash 3 Philippe Blain via GitGitGadget
2024-01-29 13:27   ` [PATCH v2 2/5] completion: complete 'submodule.*' config variables Philippe Blain via GitGitGadget
2024-02-08  7:42     ` Patrick Steinhardt
2024-02-10 15:39       ` Philippe Blain
2024-01-29 13:27   ` [PATCH v2 3/5] completion: add and use __git_compute_first_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-02-08  7:42     ` Patrick Steinhardt
2024-02-10 16:06       ` Philippe Blain
2024-02-10 17:15         ` Junio C Hamano
2024-02-10 17:27           ` Philippe Blain
2024-02-14  0:24             ` Junio C Hamano
2024-01-29 13:28   ` [PATCH v2 4/5] builtin/help: add --config-all-for-completion Philippe Blain via GitGitGadget
2024-02-08  7:42     ` Patrick Steinhardt
2024-02-10 16:13       ` Philippe Blain
2024-01-29 13:28   ` [PATCH v2 5/5] completion: add an use __git_compute_second_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-02-08  7:42     ` Patrick Steinhardt
2024-02-10 16:19       ` Philippe Blain
2024-02-07 22:08   ` Junio C Hamano [this message]
2024-02-08  7:42     ` [PATCH v2 0/5] completion: remove hardcoded config variable names Patrick Steinhardt
2024-02-10 18:32   ` [PATCH v3 0/4] " Philippe Blain via GitGitGadget
2024-02-10 18:32     ` [PATCH v3 1/4] completion: add space after config variable names also in Bash 3 Philippe Blain via GitGitGadget
2024-02-10 18:32     ` [PATCH v3 2/4] completion: complete 'submodule.*' config variables Philippe Blain via GitGitGadget
2024-02-10 18:32     ` [PATCH v3 3/4] completion: add and use __git_compute_first_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-02-10 18:32     ` [PATCH v3 4/4] completion: add and use __git_compute_second_level_config_vars_for_section Philippe Blain via GitGitGadget
2024-02-13  9:35     ` [PATCH v3 0/4] completion: remove hardcoded config variable names Patrick Steinhardt
2024-02-13 17:09       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8r3w53nc.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=levraiphilippeblain@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.