All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Patrick Steinhardt <ps@pks.im>,
	 git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>
Subject: Re: commit-graph paranoia performance, was Re: [ANNOUNCE] Git v2.43.0-rc1
Date: Tue, 14 Nov 2023 08:50:22 +0900	[thread overview]
Message-ID: <xmqq8r7143i9.fsf@gitster.g> (raw)
In-Reply-To: <20231113205538.GA2028092@coredump.intra.peff.net> (Jeff King's message of "Mon, 13 Nov 2023 15:55:38 -0500")

Jeff King <peff@peff.net> writes:

> Should we default GIT_COMMIT_GRAPH_PARANOIA to "0"? Yes, some operations
> might miss a breakage, but that is true of so much of Git. For day to
> day commands we generally assume that the repository is not corrupted,
> and avoid looking at any data we can. Other commands (like "commit-graph
> verify", but maybe others) would probably want to be more careful
> (either by checking this case explicitly, or by enabling the paranoia
> flag themselves).

I am obviously fine with that direction, as that was exactly the
stance I took when we discussed the topic on "rev-list --missing"
;-)

Patrick?  Karthik?

  reply	other threads:[~2023-11-13 23:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08 17:33 [ANNOUNCE] Git v2.43.0-rc1 Junio C Hamano
2023-11-10  7:59 ` Andy Koppe
2023-11-13 20:55 ` commit-graph paranoia performance, was " Jeff King
2023-11-13 23:50   ` Junio C Hamano [this message]
2023-11-14  8:46   ` Patrick Steinhardt
2023-11-14  9:05     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8r7143i9.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.