From: Junio C Hamano <gitster@pobox.com>
To: "Adam Johnson via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, ZheNing Hu <adlternative@gmail.com>,
Adam Johnson <me@adamj.eu>
Subject: Re: [PATCH] ls-files: fix "--format" output of relative paths
Date: Fri, 10 Mar 2023 09:39:00 -0800 [thread overview]
Message-ID: <xmqq8rg47bgr.fsf@gitster.g> (raw)
In-Reply-To: <pull.1465.git.git.1678453473484.gitgitgadget@gmail.com> (Adam Johnson via GitGitGadget's message of "Fri, 10 Mar 2023 13:04:33 +0000")
"Adam Johnson via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Adam Johnson <me@adamj.eu>
>
> Fix a bug introduced with the "--format" option in
> ce74de931d, where relative paths were computed
> using the output buffer, which could lead to
> random data in the output.
Good find. Both the explanation and the patch text are crystal
clear. Nicely done.
I'll replace "ce74de9313" above with "ce74de93 (ls-files: introduce
"--format" option, 2022-07-23)" while queuing, though.
prev parent reply other threads:[~2023-03-10 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 13:04 [PATCH] ls-files: fix "--format" output of relative paths Adam Johnson via GitGitGadget
2023-03-10 13:40 ` ZheNing Hu
2023-03-10 17:39 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8rg47bgr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adlternative@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@adamj.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.