From: Junio C Hamano <gitster@pobox.com>
To: Vivan Garg <v.garg.work@gmail.com>
Cc: Victoria Dye <vdye@github.com>, Vivan Garg <gvivan6@gmail.com>,
git@vger.kernel.org, christian.couder@gmail.com,
hariom18599@gmail.com
Subject: Re: [GSOC][PATCH] t4121: modernize test style
Date: Tue, 21 Feb 2023 12:21:50 -0800 [thread overview]
Message-ID: <xmqq8rgqeplt.fsf@gitster.g> (raw)
In-Reply-To: <CADupsJNPVm13iSv84SXpqtP8Dhm_-htPTr59yPs_J=aQzs2FwQ@mail.gmail.com> (Vivan Garg's message of "Tue, 21 Feb 2023 12:48:54 -0700")
Vivan Garg <v.garg.work@gmail.com> writes:
> I'm not sure what you mean by "next re-roll," are you referring to v2? But
> then you said it was fine in this patch, so I'm confused. If I am going to be
> sending a v2, couldn't I just revert the last commit and add this change to the
> same commit?
I am not Victoria, but I think
* You had two (or more) changes in your patch.
* She found one of them is good.
* The other one(s) were found lacking.
When a patch is reviewed and found to be lacking (as a whole), and
if you agree with the issues pointed out by the review(s), you'd
redo the patch (with either "commit --amend" for a single patch, or
"rebase -i" for a series with multiple patches), and produce v2, as
if v1 never happened. The act of doing so is colloquially called
"to reroll".
Documentation/MyFirstContribution.txt::[[now-what]] may have more
details.
Thanks.
next prev parent reply other threads:[~2023-02-21 20:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 23:51 [GSOC][PATCH] t4121: modernize test style Vivan Garg
2023-02-21 17:22 ` Victoria Dye
2023-02-21 19:48 ` Vivan Garg
2023-02-21 20:21 ` Junio C Hamano [this message]
2023-02-21 21:27 ` [GSOC][PATCH v2 0/1] " Vivan Garg
2023-02-21 21:27 ` [GSOC][PATCH v2 1/1] " Vivan Garg
2023-02-22 5:19 ` [GSOC][PATCH] " Vivan Garg
2023-02-21 21:46 ` [GSOC][PATCH v2 0/1] " Vivan Garg
2023-02-21 21:46 ` [GSOC][PATCH v2 1/1] " Vivan Garg
2023-02-21 22:05 ` Victoria Dye
2023-02-21 22:34 ` Vivan Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8rgqeplt.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gvivan6@gmail.com \
--cc=hariom18599@gmail.com \
--cc=v.garg.work@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.