From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>, rsbecker@nexbridge.com
Subject: Re: [PATCH] test-genzeros: avoid raw write(2)
Date: Thu, 16 Feb 2023 08:09:49 -0800 [thread overview]
Message-ID: <xmqq8rgxtwvm.fsf@gitster.g> (raw)
In-Reply-To: <Y+2ycMAkVd8rh50q@coredump.intra.peff.net> (Jeff King's message of "Wed, 15 Feb 2023 23:34:56 -0500")
Jeff King <peff@peff.net> writes:
>> I ended up avoiding write_or_die() primarily because there is
>> nothing "Git" about this helper, which is a poor-man's emulation
>> of "dd if=/dev/zero". It felt a bit too much to pull cache.h in
>> as dependency for it.
>
> I don't find it any more "Git" than xwrite() or die_errno(), really, but
> I am quite happy with what you have here.
True. I view "git-compat-util.h" as "projects, not limited to Git,
would benefit by its help to use POSIX api more sensibly", while
"cache.h" is "things that are about Git". write_or_die() is certainly
in the former category, but is not available without "cache.h" X-<.
next prev parent reply other threads:[~2023-02-16 16:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 17:44 [Bug] Test 1450.91 Fails on NonStop rsbecker
2023-02-15 17:59 ` rsbecker
2023-02-15 18:02 ` Jeff King
2023-02-15 18:49 ` rsbecker
2023-02-15 19:10 ` Junio C Hamano
2023-02-15 19:41 ` rsbecker
2023-02-15 19:59 ` Jeff King
2023-02-16 1:45 ` Junio C Hamano
2023-02-16 2:56 ` [PATCH] test-genzeros: avoid raw write(2) Junio C Hamano
2023-02-16 4:34 ` Jeff King
2023-02-16 16:09 ` Junio C Hamano [this message]
2023-02-16 16:14 ` rsbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8rgxtwvm.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.