From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Fabian Stelzer <fs@gigacodes.de>,
git@vger.kernel.org, Adam Dinwoodie <adam@dinwoodie.org>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH 1/2] test-lib: show missing prereq summary
Date: Mon, 15 Nov 2021 09:53:10 -0800 [thread overview]
Message-ID: <xmqq8rxpfgqh.fsf@gitster.g> (raw)
In-Reply-To: <211115.865ysts45o.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 15 Nov 2021 18:44:14 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>> +if test -n "$missing_prereq"
>> +then
>> + unique_missing_prereq=$(
>> + echo $missing_prereq |
>> + tr -s "," "\n" |
>> + grep -v '^$' |
>> + sort -u |
>> + paste -s -d ',')
>
> What is paste? Some out-of-tree debugging utility?
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/paste.html
Don't feel bad for not knowing it. I usually do not use cut or paste
myself and I had to look it up the other day while reviewing the RFC
phase of this series.
I am not sure '\n' is a good idea from portability perspective. I
thought I wrote '\012' in the illustration in my review?
next prev parent reply other threads:[~2021-11-15 17:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 16:07 [PATCH 0/2] test-lib: improve missing prereq handling Fabian Stelzer
2021-11-15 16:07 ` [PATCH 1/2] test-lib: show missing prereq summary Fabian Stelzer
2021-11-15 17:44 ` Ævar Arnfjörð Bjarmason
2021-11-15 17:53 ` Junio C Hamano [this message]
2021-11-15 19:56 ` Fabian Stelzer
2021-11-15 22:10 ` Junio C Hamano
2021-11-16 14:19 ` Fabian Stelzer
2021-11-17 8:19 ` Junio C Hamano
2021-11-17 9:05 ` Fabian Stelzer
2021-11-15 16:07 ` [PATCH 2/2] test-lib: introduce required prereq for test runs Fabian Stelzer
2021-11-16 6:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8rxpfgqh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adam@dinwoodie.org \
--cc=avarab@gmail.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.