From: Junio C Hamano <gitster@pobox.com>
To: Jeff Hostetler <git@jeffhostetler.com>
Cc: git@vger.kernel.org, peff@peff.net, jonathantanmy@google.com,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH] dir: allow exclusions from blob in addition to file
Date: Fri, 27 Oct 2017 10:20:24 +0900 [thread overview]
Message-ID: <xmqq8tfxe693.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171026180222.39421-2-git@jeffhostetler.com> (Jeff Hostetler's message of "Thu, 26 Oct 2017 18:02:22 +0000")
Jeff Hostetler <git@jeffhostetler.com> writes:
> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> Refactor add_excludes() to separate the reading of the
> exclude file into a buffer and the parsing of the buffer
> into exclude_list items.
>
> Add add_excludes_from_blob_to_list() to allow an exclude
> file be specified with an OID without assuming a local
> worktree or index exists.
>
> Refactor read_skip_worktree_file_from_index() and add
> do_read_blob() to eliminate duplication of preliminary
> processing of blob contents.
>
> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
> ---
Yeah, with a separate do_read_blob() helper, this one looks a lot
easier to follow, at least to me---as the author, you might find the
earlier one just as easy, I suspect, though ;-)
Thanks. Will queue.
next prev parent reply other threads:[~2017-10-27 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 18:02 [PATCH] dir: allow exclusions from blob in addition to file Jeff Hostetler
2017-10-26 18:02 ` Jeff Hostetler
2017-10-27 1:20 ` Junio C Hamano [this message]
2017-10-27 15:02 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8tfxe693.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.