All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] comment: fix a typo in the comment
Date: Wed, 05 Jul 2017 11:18:00 -0700	[thread overview]
Message-ID: <xmqq8tk2iw87.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170705170324.21026-1-kaarticsivaraam91196@gmail.com> (Kaartic Sivaraam's message of "Wed, 5 Jul 2017 22:33:24 +0530")

Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:

> ---
>  Though very trivial, I wanted to correct this as I didn't
>  want to ignore it after seeing it.

Thanks for sharp eyes.  Sign-off?  (or Sign-of? ;-))

>
>  builtin/commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/commit.c b/builtin/commit.c
> index 8d1cac0..aff6bf7 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -984,7 +984,7 @@ static int rest_is_empty(struct strbuf *sb, int start)
>  	int i, eol;
>  	const char *nl;
>  
> -	/* Check if the rest is just whitespace and Signed-of-by's. */
> +	/* Check if the rest is just whitespace and Signed-off-by's. */
>  	for (i = start; i < sb->len; i++) {
>  		nl = memchr(sb->buf + i, '\n', sb->len - i);
>  		if (nl)

  reply	other threads:[~2017-07-05 18:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 17:03 [PATCH] comment: fix a typo in the comment Kaartic Sivaraam
2017-07-05 18:18 ` Junio C Hamano [this message]
2017-07-06  3:17   ` Kaartic Sivaraam
2017-07-06 14:47     ` SZEDER Gábor
2017-07-06 16:04       ` Junio C Hamano
2017-07-07 16:02         ` [PATCH] commit: " Kaartic Sivaraam
2017-07-06  3:19   ` [PATCH] comment: " Kaartic Sivaraam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8tk2iw87.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kaarticsivaraam91196@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.