Re: [PATCH v8 0/11] Port tag.c over to use ref-filter APIs

[Junio C Hamano <gitster@pobox.com>]

Karthik Nayak <karthik.188@gmail.com> writes:

> This is part of my GSoC project to unify git tag -l, git branch -l,
> git for-each-ref.  This patch series is continued from: Git (next)
> https://github.com/git/git/commit/bf5418f49ff0cebc6e5ce04ad1417e1a47c81b61
>
> This series consists of porting tag.c over to using the ref-filter APIs
>
> Version 7 can be found here:
> http://thread.gmane.org/gmane.comp.version-control.git/274990
>
> Changes:
> * Make padright a general align atom.
> * Make print_value() and emit() output to a strbuf rather than stdout directly.
>
> Interdiff:
>
> diff --git a/Documentation/git-for-each-ref.txt
> b/Documentation/git-for-each-ref.txt
> index bcf319a..e89b9b0 100644
> --- a/Documentation/git-for-each-ref.txt
> +++ b/Documentation/git-for-each-ref.txt
> @@ -127,11 +127,12 @@ color::
>      Change output color.  Followed by `:<colorname>`, where names
>      are described in `color.branch.*`.
>
> -padright::
> -    Pad succeeding atom or string to the right. Followed by
> -    `:<value>`, where `value` states the total length of atom or
> -    string including the padding. If the `value` is lesser than
> -    the atom or string length, then no padding is performed.
> +align::
> +    Align succeeding atoms to the right, left or middle. Followed
> +    by `:<type>,<paddinglength>`, where the `<type>` is either
> +    left, right or middle and `<paddinglength>` is the total
> +    length of the padding to be performed. If the atom length is
> +    more than the padding length then no padding is performed.

It is very very dissapointing to allow the "next atom only"
implementation to squat on a good name "align:<type>,<width>",
especially when I thought that the list agreed

  %(align:<type>,<width>) any string with or without %(atom) %(end)

would be the way to go.