All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Michael <fedora.dm0@gmail.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v2] compat: convert modes to use portable file type values
Date: Thu, 04 Dec 2014 11:39:19 -0800	[thread overview]
Message-ID: <xmqq8uintdaw.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAEvUa7nxzX=54QJto_R3hfvAO4FKhs8Pancz0TTiC7ev22--Kw@mail.gmail.com> (David Michael's message of "Thu, 4 Dec 2014 14:27:24 -0500")

David Michael <fedora.dm0@gmail.com> writes:

> On Wed, Dec 3, 2014 at 9:24 PM, David Michael <fedora.dm0@gmail.com> wrote:
>> --- /dev/null
>> +++ b/compat/stat.c
>> @@ -0,0 +1,49 @@
>> +#define _POSIX_C_SOURCE 200112L
>> +#include <stddef.h>    /* NULL         */
>> +#include <sys/stat.h>  /* *stat, S_IS* */
>> +#include <sys/types.h> /* mode_t       */
>
> Oops, the <stddef.h> line can be removed now that this is no longer
> testing for NULL.  Let me know if this warrants a v3 if there is no
> other feedback.

Let me queue with this squashed in for now.

 compat/stat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/compat/stat.c b/compat/stat.c
index c2d4711..a2d3931 100644
--- a/compat/stat.c
+++ b/compat/stat.c
@@ -1,5 +1,4 @@
 #define _POSIX_C_SOURCE 200112L
-#include <stddef.h>    /* NULL         */
 #include <sys/stat.h>  /* *stat, S_IS* */
 #include <sys/types.h> /* mode_t       */
 

      reply	other threads:[~2014-12-04 19:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04  2:24 [PATCH v2] compat: convert modes to use portable file type values David Michael
2014-12-04 19:27 ` David Michael
2014-12-04 19:39   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8uintdaw.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=fedora.dm0@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.