From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Jens Lindström" <jl@opera.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Clear fd after closing to avoid double-close error
Date: Tue, 22 Oct 2013 11:42:30 -0700 [thread overview]
Message-ID: <xmqq8uxltaeh.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CACsJy8DtvaojrrQr4=uYCRse7N+SXb+WdjY+C_0FRSjYsNC6zg@mail.gmail.com> (Duy Nguyen's message of "Tue, 22 Oct 2013 19:39:08 +0700")
Duy Nguyen <pclouds@gmail.com> writes:
> On Tue, Oct 22, 2013 at 7:10 PM, Jens Lindström <jl@opera.com> wrote:
> ...
>> + if (!args->stateless_rpc)
>> + /* Closed by pack_objects() via start_command() */
>> + fd[1] = -1;
>> }
> ...
> Life would have been simpler if fd[1] was _always_ closed by
> send_pack(), like in c20181e (start_command(), if .in/.out > 0, closes
> file descriptors, not the callers - 2008-02-21).
Yeah, that was also my first reaction when I saw the above three
lines after reading the discussion that led to the diagnosis.
next prev parent reply other threads:[~2013-10-22 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 12:10 [PATCH] Clear fd after closing to avoid double-close error Jens Lindström
2013-10-22 12:39 ` Duy Nguyen
2013-10-22 13:15 ` Jens Lindström
2013-10-22 18:42 ` Junio C Hamano [this message]
2013-10-23 7:52 ` Jens Lindström
2013-10-23 16:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8uxltaeh.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jl@opera.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.