All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Omri Sarig <omri.sarig13@gmail.com>
Cc: taahol@utu.fi,  git@vger.kernel.org,  julia@jvns.ca,
	 me@linux.beauty, phillip.wood@dunelm.org.uk
Subject: Re: [PATCH v6] doc: git-rebase: update incompatible options
Date: Tue, 10 Nov 2026 10:10:46 -0800	[thread overview]
Message-ID: <xmqqa4ngsgk9.fsf@gitster.g> (raw)
In-Reply-To: <20261101082230.141688-1-omri.sarig13@gmail.com> (Omri Sarig's message of "Sun, 1 Nov 2026 09:22:30 +0100")

Omri Sarig <omri.sarig13@gmail.com> writes:

> Changes in V6:
> - Update the commit message per the review comments, making it clearer.
>
>  Documentation/git-rebase.adoc | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/git-rebase.adoc b/Documentation/git-rebase.adoc
> index f6c22d1598..f1f675d311 100644
> --- a/Documentation/git-rebase.adoc
> +++ b/Documentation/git-rebase.adoc
> @@ -217,6 +217,8 @@ OPTIONS
>  As a special case, you may use "A\...B" as a shortcut for the
>  merge base of A and B if there is exactly one merge base. You can
>  leave out at most one of A and B, in which case it defaults to HEAD.
> ++
> +See also INCOMPATIBLE OPTIONS below.
>  
>  See TRANSPLANTING A TOPIC BRANCH WITH --ONTO above for examples.
>  
> @@ -332,8 +334,6 @@ See also INCOMPATIBLE OPTIONS below.
>  	and this option would override that behavior, allowing commits
>  	with empty messages to be rebased.  Now commits with an empty
>  	message do not cause rebasing to halt.
> -+
> -See also INCOMPATIBLE OPTIONS below.
>  
>  -m::
>  --merge::
> @@ -487,15 +487,11 @@ applying (in terms of the author date).
>  	Instead of using the author date of the original commit, use
>  	the current time as the	author date of the rebased commit.  This
>  	option implies `--force-rebase`.
> -+
> -See also INCOMPATIBLE OPTIONS below.
>  
>  --signoff::
>  	Add a `Signed-off-by` trailer to all the rebased commits. Note
>  	that if `--interactive` is given then only commits marked to be
>  	picked, edited or reworded will have the trailer added.
> -+
> -See also INCOMPATIBLE OPTIONS below.
>  
>  --trailer=<trailer>::
>  	Append the given trailer to every rebased commit message, processed

Looking good.  Let's mark it as ready for 'next'.


      parent reply	other threads:[~2026-11-10 18:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25 11:07 [PATCH v4] doc: git-rebase: update incompatible options Omri Sarig
2026-10-29  8:03 ` Tuomas Ahola
2026-10-30 16:38 ` [PATCH v5] " Omri Sarig
2026-10-30 19:27   ` Tuomas Ahola
2026-10-30 19:31     ` Junio C Hamano
2026-10-30 19:57       ` Tuomas Ahola
2026-11-01  8:22 ` [PATCH v6] " Omri Sarig
2026-11-09 17:23   ` Omri Sarig
2026-11-10 14:06   ` Julia Evans
2026-11-10 15:37     ` Omri Sarig
2026-11-10 17:59       ` Julia Evans
2026-11-10 18:10   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa4ngsgk9.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=julia@jvns.ca \
    --cc=me@linux.beauty \
    --cc=omri.sarig13@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=taahol@utu.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.