From: Junio C Hamano <gitster@pobox.com>
To: Brigham Campbell <me@brighamcampbell.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2] git-contacts: allow inputting patch via stdin
Date: Wed, 16 Sep 2026 07:25:55 -0700 [thread overview]
Message-ID: <xmqqa4phxogc.fsf@gitster.g> (raw)
In-Reply-To: <20260915-git-contacts-stdin-v2-1-2005061d907a@brighamcampbell.com> (Brigham Campbell's message of "Tue, 15 Sep 2026 22:52:23 -0600")
Brigham Campbell <me@brighamcampbell.com> writes:
> # git-send-email --cc-cmd option, and in other situations.
> #
> # Usage: git contacts <file | rev-list option> ...
> +# git contacts < <patch>
Not necessarily a suggestion to change what you already added, but a
mere food for thought.
An obvious (and UNIX-y) alternative design would have been to follow
the popular convention to tell the command to read from the standard
input stream when "-" is used instead of a filename. Then this line
did not have to change, and the command would have allowed arguments
like:
$ git contacts patch1 patch2 - <patch3
$ git contacts patch1 - patch3 <patch2
next prev parent reply other threads:[~2026-09-16 14:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 2:43 [PATCH] git-contacts: allow inputting patch via stdin Brigham Campbell
2026-09-15 4:29 ` Junio C Hamano
2026-09-16 4:52 ` [PATCH v2] " Brigham Campbell
2026-09-16 14:25 ` Junio C Hamano [this message]
2026-09-17 6:56 ` Brigham Campbell
2026-09-24 1:25 ` [PATCH v3] " Brigham Campbell
2026-09-24 4:13 ` Junio C Hamano
2026-09-25 1:51 ` Brigham Campbell
2026-09-25 4:38 ` Junio C Hamano
2026-09-25 6:42 ` [PATCH v4] " Brigham Campbell
2026-09-25 16:09 ` Junio C Hamano
2026-09-29 5:47 ` [PATCH v5 0/2] " Brigham Campbell
2026-09-29 5:47 ` [PATCH v5 1/2] " Brigham Campbell
2026-09-29 19:29 ` Junio C Hamano
2026-10-02 4:44 ` Brigham Campbell
2026-09-29 5:47 ` [PATCH v5 2/2] git-contacts: add stdin functionality to docs Brigham Campbell
2026-09-29 16:30 ` [PATCH v5 0/2] git-contacts: allow inputting patch via stdin Junio C Hamano
2026-10-02 6:50 ` [PATCH v6] " Brigham Campbell
2026-10-02 14:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa4phxogc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@brighamcampbell.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.