All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Harald Nordgren <haraldnordgren@gmail.com>
Cc: Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v2] ci: cancel stale pull request workflow runs
Date: Mon, 31 Aug 2026 07:33:50 -0700	[thread overview]
Message-ID: <xmqqa4q2z7e9.fsf@gitster.g> (raw)
In-Reply-To: <CAHwyqnV5YTJsAnDDHQj0gwmoWXEgnPSJ8tJCcXrg12vBvtwFfA@mail.gmail.com> (Harald Nordgren's message of "Mon, 31 Aug 2026 13:12:32 +0200")

Harald Nordgren <haraldnordgren@gmail.com> writes:

>> If a user has CI enabled on their own repository, pushes a commit
>> there, and opens a pull request, wouldn't GitHub Actions trigger
>> two events for the same commit at the tip of the pushed branch?
>>
>> Before this change, both events are assigned to the same concurrency
>> group (the commit object name).  One waits while the other runs, and
>> the skip-if-redundant logic stops the second one early without
>> wasting cycles on the same commit.  With this change, the
>> concurrency groups for these two events are separate.  Would we end
>> up building and testing the same commit twice in parallel?
>>
>> I suspect this may not be a problem in practice given how our
>> contributors use GitHub Actions in our official repositories (either
>> those owned by gitgitgadget or git).  They push to their own
>> repositories where CI may not be enabled, so 'push' does not
>> trigger.  Still, I thought it better to bring this up before the
>> change gets merged and wastes build cycles.
>
> Concurrency groups don't span repos, so I don't see a solution to that.

OK, then I do not see a need for solution to begin with---it is not
a problem, in other words ;-).

Thanks.

  reply	other threads:[~2026-08-31 14:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 10:10 [PATCH] ci: cancel stale pull request workflow runs Harald Nordgren via GitGitGadget
2026-08-21 11:14 ` Harald Nordgren
2026-08-26 19:54 ` Junio C Hamano
2026-08-30 10:59 ` [PATCH v2] " Harald Nordgren via GitGitGadget
2026-08-30 22:54   ` Junio C Hamano
2026-08-31 11:12     ` Harald Nordgren
2026-08-31 14:33       ` Junio C Hamano [this message]
2026-08-31 16:18 ` [PATCH v3] " Harald Nordgren via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa4q2z7e9.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=haraldnordgren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.