From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Patrick Steinhardt <ps@pks.im>,
Ben Knoble <ben.knoble@gmail.com>, Jeff King <peff@peff.net>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Randall S. Becker" <randall.becker@nexbridge.ca>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH 0/5] Reintroduce writev(3p)
Date: Wed, 05 Aug 2026 13:29:44 -0700 [thread overview]
Message-ID: <xmqqa4r0payv.fsf@gitster.g> (raw)
In-Reply-To: <8ff3c3ea-2604-4d65-8a7d-6acd6218b7c2@kdbg.org> (Johannes Sixt's message of "Wed, 5 Aug 2026 22:00:51 +0200")
Johannes Sixt <j6t@kdbg.org> writes:
> Am 05.08.26 um 20:40 schrieb Junio C Hamano:
>> I think it is OK to explicitly document that any writev(2) emulation
>> is allowed to be non-atomic, and it is also OK to declare that using
>> writev(2) in this application to allow competing writes to the same
>> destination is a bug.
>
> These are fine.
>
> But I'm not worried about current uses of writev, I'm worried about
> future uses: "Look, we already use writev elsewhere. Let's use it here,
> too, where we can take adavantage of the atomicity of the write." It's
> too easy to miss a note about non-atomic emulations when the function
> name advertises more than can be guaranteed. For this reason, I strongly
> suggest to use a different name.
That is why I added the "it is also OK to declare" in the above.
next prev parent reply other threads:[~2026-08-05 20:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 7:52 [PATCH 0/5] Reintroduce writev(3p) Patrick Steinhardt
2026-07-16 7:52 ` [PATCH 1/5] compat/posix: introduce writev(3p) wrapper Patrick Steinhardt
2026-07-16 8:47 ` Simon Richter
2026-07-16 20:09 ` Junio C Hamano
2026-07-16 20:44 ` Junio C Hamano
2026-08-05 8:30 ` Patrick Steinhardt
2026-07-16 7:52 ` [PATCH 2/5] wrapper: introduce writev(3p) wrappers Patrick Steinhardt
2026-07-16 7:52 ` [PATCH 3/5] wrapper: properly handle MAX_IO_SIZE in writev(3p) Patrick Steinhardt
2026-07-16 7:52 ` [PATCH 4/5] sideband: use writev(3p) to send pktlines Patrick Steinhardt
2026-07-16 7:52 ` [PATCH 5/5] fast-import: use writev(3p) to send cat-blob responses Patrick Steinhardt
2026-07-16 18:56 ` [PATCH 0/5] Reintroduce writev(3p) Johannes Sixt
2026-07-27 15:44 ` Junio C Hamano
2026-08-05 8:30 ` Patrick Steinhardt
2026-08-05 16:36 ` Junio C Hamano
2026-08-05 17:55 ` Johannes Sixt
2026-08-05 18:40 ` Junio C Hamano
2026-08-05 20:00 ` Johannes Sixt
2026-08-05 20:29 ` Junio C Hamano [this message]
2026-08-06 6:28 ` Patrick Steinhardt
2026-08-06 20:26 ` Junio C Hamano
2026-08-07 6:29 ` Patrick Steinhardt
2026-08-07 6:18 ` [PATCH v2 " Patrick Steinhardt
2026-08-07 6:18 ` [PATCH v2 1/5] compat/posix: introduce writev(3p) wrapper Patrick Steinhardt
2026-08-07 6:18 ` [PATCH v2 2/5] wrapper: introduce writev(3p) wrappers Patrick Steinhardt
2026-08-07 6:18 ` [PATCH v2 3/5] wrapper: properly handle MAX_IO_SIZE in writev(3p) Patrick Steinhardt
2026-08-07 6:18 ` [PATCH v2 4/5] sideband: use writev(3p) to send pktlines Patrick Steinhardt
2026-08-07 6:18 ` [PATCH v2 5/5] fast-import: use writev(3p) to send cat-blob responses Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa4r0payv.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
--cc=randall.becker@nexbridge.ca \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.