From: Junio C Hamano <gitster@pobox.com>
To: Ritesh Singh Jadoun <riteshjd75@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] t/pack-refs-tests: use test_path_is_missing
Date: Mon, 16 Mar 2026 08:25:50 -0700 [thread overview]
Message-ID: <xmqqa4w7re2p.fsf@gitster.g> (raw)
In-Reply-To: <20260315081032.497-1-riteshjd75@gmail.com> (Ritesh Singh Jadoun's message of "Sun, 15 Mar 2026 13:40:32 +0530")
Ritesh Singh Jadoun <riteshjd75@gmail.com> writes:
> The pack-refs tests previously used raw 'test -f' and 'test -e' checks
> with negation. Update them to use Git's standard helper function
> test_path_is_missing for consistency and clearer failure reporting.
>
> As suggested in review, replaced the negated 'test_path_exists' with
> test_path_is_missing to better reflect the expected absence of paths.
>
> Signed-off-by: Ritesh Singh Jadoun <riteshjd75@gmail.com>
> ---
> t/pack-refs-tests.sh | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
This round looks very good. Thanks. Will queue.
next prev parent reply other threads:[~2026-03-16 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 8:10 [PATCH v2] t/pack-refs-tests: use test_path_is_missing Ritesh Singh Jadoun
2026-03-16 15:25 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-14 6:05 Ritesh Singh Jadoun
2026-03-14 16:39 ` Junio C Hamano
2026-03-14 3:46 Ritesh Singh Jadoun
2026-03-14 5:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa4w7re2p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=riteshjd75@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.