All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Ezekiel Newren <ezekielnewren@gmail.com>,
	 "brian m. carlson" <sandals@crustytoothpaste.net>,
	 Karthik Nayak <karthik.188@gmail.com>,
	 Eric Sunshine <ericsunshine@gmail.com>,
	 Chris Torek <chris.torek@gmail.com>,
	 Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2 0/6] ci: improvements to our Rust infrastructure
Date: Thu, 09 Oct 2025 12:29:31 -0700	[thread overview]
Message-ID: <xmqqa51zeuw4.fsf@gitster.g> (raw)
In-Reply-To: <20251008-b4-pks-ci-rust-v2-0-d556ee83c381@pks.im> (Patrick Steinhardt's message of "Wed, 08 Oct 2025 08:27:11 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> Changes in v2:
>   - Adjust comments for `encode_varint()` and `decode_varint()` based on
>     brian's feedback.
>   - Some small improvements to commit messages.
>   - Not changed is the default column limit used by Rust. I think using
>     the column limit of 100 used by the Rust ecosystem is sensible, but
>     if there is a majority advocating for a limit of 80 I'll adapt this.
>   - Link to v1: https://lore.kernel.org/r/20251007-b4-pks-ci-rust-v1-0-394502abe7ea@pks.im

OK.  I am ambivalent on the column limit one, but otherwise, this
topic looks quite well done already.

Thanks.

      parent reply	other threads:[~2025-10-09 19:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08  6:27 [PATCH v2 0/6] ci: improvements to our Rust infrastructure Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 1/6] ci: deduplicate calls to `apt-get update` Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 2/6] ci: check formatting of our Rust code Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 3/6] rust/varint: add safety comments Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 4/6] ci: check for common Rust mistakes via Clippy Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 5/6] ci: verify minimum supported Rust version Patrick Steinhardt
2025-10-08  6:27 ` [PATCH v2 6/6] rust: support for Windows Patrick Steinhardt
2025-10-08 12:04 ` [PATCH v2 0/6] ci: improvements to our Rust infrastructure Patrick Steinhardt
2025-10-09 19:29 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa51zeuw4.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=chris.torek@gmail.com \
    --cc=ericsunshine@gmail.com \
    --cc=ezekielnewren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.