From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH] rev-list: make "struct rev_list_info" static to the only user
Date: Fri, 18 Jul 2025 16:58:03 -0700 [thread overview]
Message-ID: <xmqqa551127o.fsf@gitster.g> (raw)
The structure has nothing to do with what "git bisect" does; as
nobody other than "git rev-list" implementation uses it, move it
as a private data type to builtin/rev-list.c
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
* https://lore.kernel.org/git/xmqq1qdptffk.fsf@gitster.g/ had this
#leftoverbits tangent.
bisect.h | 8 --------
builtin/rev-list.c | 10 +++++++++-
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/bisect.h b/bisect.h
index 944439bfac..8621460f93 100644
--- a/bisect.h
+++ b/bisect.h
@@ -27,14 +27,6 @@ struct commit_list *filter_skipped(struct commit_list *list,
#define FIND_BISECTION_ALL (1u<<0)
#define FIND_BISECTION_FIRST_PARENT_ONLY (1u<<1)
-struct rev_list_info {
- struct rev_info *revs;
- int flags;
- int show_timestamp;
- int hdr_termination;
- const char *header_prefix;
-};
-
/*
* enum bisect_error represents the following return codes:
* BISECT_OK: success code. Internally, it means that next
diff --git a/builtin/rev-list.c b/builtin/rev-list.c
index 0984b607bf..0a89f4cbf7 100644
--- a/builtin/rev-list.c
+++ b/builtin/rev-list.c
@@ -28,6 +28,14 @@
#include "quote.h"
#include "strbuf.h"
+struct rev_list_info {
+ struct rev_info *revs;
+ int flags;
+ int show_timestamp;
+ int hdr_termination;
+ const char *header_prefix;
+};
+
static const char rev_list_usage[] =
"git rev-list [<options>] <commit>... [--] [<path>...]\n"
"\n"
@@ -652,7 +660,7 @@ int cmd_rev_list(int argc,
*/
/*
* NEEDSWORK: These loops that attempt to find presence of
- * options without understanding that the options they are
+ * options without understanding the options they are
* skipping are broken (e.g., it would not know "--grep
* --exclude-promisor-objects" is not triggering
* "--exclude-promisor-objects" option). We really need
--
2.50.1-446-g8227aac02a
next reply other threads:[~2025-07-18 23:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 23:58 Junio C Hamano [this message]
2025-07-19 6:35 ` [PATCH] rev-list: make "struct rev_list_info" static to the only user Jeff King
2025-07-19 12:36 ` René Scharfe
2025-07-20 0:04 ` Jeff King
2025-07-20 0:41 ` Junio C Hamano
2025-07-21 22:46 ` [PATCH] rev-list: update a NEEDSWORK comment Junio C Hamano
2025-07-22 8:16 ` Jeff King
2025-07-22 8:41 ` Kristoffer Haugsbakk
2025-07-22 13:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa551127o.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.