All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: phillip.wood123@gmail.com
Cc: Li Chen <me@linux.beauty>,
	 phillipwood <phillip.wood@dunelm.org.uk>,
	git <git@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] trailer: append trailers in-process and drop the fork to `interpret-trailers`
Date: Wed, 11 Jun 2025 08:34:07 -0700	[thread overview]
Message-ID: <xmqqa56ejnrk.fsf@gitster.g> (raw)
In-Reply-To: <407631ab-1184-41b1-8043-fd91d860e845@gmail.com> (phillip's message of "Wed, 11 Jun 2025 10:15:26 +0100")

phillip.wood123@gmail.com writes:

> Exactly - I was expecting to see a refactoring of interpret_trailers()
> in builtin/interpret-trailers.c that moved most of the function body
> into a new function in trailer.c that added the trailers to an
> strbuf. This seems to be a parallel implementation which doesn't sound
> like the best plan.
>
> I'm going to be off the list for a couple of weeks, I'll take a more
> detailed look at this series when I'm back

Thanks.

  reply	other threads:[~2025-06-11 15:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10 12:34 [PATCH v2 0/2] rebase: support --trailer Li Chen
2025-06-10 12:34 ` [PATCH v2 1/2] trailer: append trailers in-process and drop the fork to `interpret-trailers` Li Chen
2025-06-11  0:09   ` Junio C Hamano
2025-06-11  9:15     ` phillip.wood123
2025-06-11 15:34       ` Junio C Hamano [this message]
2025-06-12  5:40         ` Li Chen
2025-06-10 12:34 ` [PATCH v2 2/2] rebase: support --trailer Li Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa56ejnrk.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@linux.beauty \
    --cc=phillip.wood123@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.