All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Matheus Tavares <matheus.tavb@gmail.com>,
	 git@vger.kernel.org, johannes.schindelin@gmx.de,
	 newren@gmail.com,  Rodrigo Siqueira <siqueirajordao@riseup.net>
Subject: Re: [PATCH] rebase -x: don't print "Executing:" msgs with --quiet
Date: Fri, 16 Aug 2024 10:34:05 -0700	[thread overview]
Message-ID: <xmqqa5hcl6cy.fsf@gitster.g> (raw)
In-Reply-To: <Zr8NOh-gMuhp-p0M@tanuki> (Patrick Steinhardt's message of "Fri, 16 Aug 2024 10:26:34 +0200")

Patrick Steinhardt <ps@pks.im> writes:

>>  			if (res) {
>
> Do we also want to add a test for this fix?
>
> Other than those nits the fix looks obviously correct to me, thanks!

Thanks for a review.  I agree that this is almost there but would
want a test.


  reply	other threads:[~2024-08-16 17:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16  3:26 [PATCH] rebase -x: don't print "Executing:" msgs with --quiet Matheus Tavares
2024-08-16  6:20 ` Elijah Newren
2024-08-16  8:26 ` Patrick Steinhardt
2024-08-16 17:34   ` Junio C Hamano [this message]
2024-08-16 22:48 ` [PATCH v2] " Matheus Tavares
2024-08-17 11:22   ` Junio C Hamano
2024-08-18 13:03     ` Matheus Tavares Bernardino
2024-08-19 13:57       ` Phillip Wood
2024-08-19 20:17         ` Junio C Hamano
2024-08-20 22:23         ` Matheus Tavares Bernardino
2024-08-19 15:41       ` Junio C Hamano
2024-08-21  1:31   ` [PATCH v3] rebase --exec: respect --quiet Matheus Tavares
2024-08-21 16:00     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa5hcl6cy.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=matheus.tavb@gmail.com \
    --cc=newren@gmail.com \
    --cc=ps@pks.im \
    --cc=siqueirajordao@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.