All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Cc: git@vger.kernel.org,  Karthik Nayak <karthik.188@gmail.com>,
	 Patrick Steinhardt <ps@pks.im>,
	 Christian Couder <christian.couder@gmail.com>,
	Christian Couder <chriscool@tuxfamily.org>,
	 Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Subject: Re: [GSoC][PATCH v3] t: migrate t0110-urlmatch-normalization to the new framework
Date: Wed, 14 Aug 2024 09:52:36 -0700	[thread overview]
Message-ID: <xmqqa5hf11yj.fsf@gitster.g> (raw)
In-Reply-To: <20240814142057.94671-1-shyamthakkar001@gmail.com> (Ghanshyam Thakkar's message of "Wed, 14 Aug 2024 19:50:46 +0530")

Ghanshyam Thakkar <shyamthakkar001@gmail.com> writes:

> And since we can construct strings with arbitrary bytes in C, let's
> also remove the test files which contain URLs with arbitrary bytes in
> the 't/t0110' directory and instead embed those URLs in the unit test
> code itself.

Yeah, that was what I meant to say.  As long as we do not have an
embedded NUL in these test pattern strings, "const char *" literals
are fine (and if we need to use embedded NUL, we'd need <ptr,len>).

Thanks.  Will queue.

  reply	other threads:[~2024-08-14 16:52 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28 12:56 [GSoC][PATCH] t: migrate helper/test-urlmatch-normalization to unit tests Ghanshyam Thakkar
2024-07-09  0:42 ` Ghanshyam Thakkar
2024-07-22 12:53 ` Karthik Nayak
2024-07-22 12:54   ` Ghanshyam Thakkar
2024-07-23  8:26     ` Karthik Nayak
2024-07-23 14:00 ` Patrick Steinhardt
2024-07-24  0:24   ` Ghanshyam Thakkar
2024-07-24  5:19     ` Patrick Steinhardt
2024-07-24  7:06       ` Ghanshyam Thakkar
2024-07-24  7:45         ` Patrick Steinhardt
2024-08-13 17:24 ` [GSoC][PATCH v2] t: migrate t0110-urlmatch-normalization to the new framework Ghanshyam Thakkar
2024-08-13 19:22   ` Junio C Hamano
2024-08-14  1:35     ` Kaartic Sivaraam
2024-08-14  4:58       ` Junio C Hamano
2024-08-14 14:24     ` Ghanshyam Thakkar
2024-08-14  5:17   ` Kaartic Sivaraam
2024-08-14 14:20   ` [GSoC][PATCH v3] " Ghanshyam Thakkar
2024-08-14 16:52     ` Junio C Hamano [this message]
2024-08-19 12:46     ` Christian Couder
2024-08-20 15:19     ` [GSoC][PATCH v4] " Ghanshyam Thakkar
2024-08-20 15:24       ` Ghanshyam Thakkar
2024-08-21 10:06       ` Christian Couder
2024-08-21 16:08         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa5hf11yj.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=karthik.188@gmail.com \
    --cc=ps@pks.im \
    --cc=shyamthakkar001@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.