All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alexander Shopov <ash@kambanaria.org>
Cc: git@vger.kernel.org,  worldhello.net@gmail.com
Subject: Re: [Improvements on messages 0/5] Disambuiguate between options and commands
Date: Fri, 16 Feb 2024 10:43:31 -0800	[thread overview]
Message-ID: <xmqqa5o0i71o.fsf@gitster.g> (raw)
In-Reply-To: <20240216101647.28837-1-ash@kambanaria.org> (Alexander Shopov's message of "Fri, 16 Feb 2024 11:15:32 +0100")

Alexander Shopov <ash@kambanaria.org> writes:

> These are trivial fixes to messages.
> They make sure commands and options are markes as such.
> This will help translators and end users.
> This will also reduce the special cases Jiang Xin keeps
> for git-po-helper which will ease maintenance.
>
> I am basing these on maint but I have also checked that
> they ar still relevant by cherry picking on top of latest and next.

I've looked at all of them and they looked sensible.

The changes look like this:

	-	die(_("something option something: %s"), arg);
	+	die(_("something --option something: %s"), arg);

It is not a fault of this patch, but wasn't the concensus that the
ideal form would be more like this:

		die(_("something %s something: %s"), "--option", arg);

in order to completely avoid tempting translators into touching
"--option", IIRC?

These patches do not make things worse, so I am willing to say they
are strict improvements and the series is a good first step if we
wanted to follow through to eject option names out of translatable
strings later.

Thanks.

  parent reply	other threads:[~2024-02-16 18:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 10:15 [Improvements on messages 0/5] Disambuiguate between options and commands Alexander Shopov
2024-02-16 10:15 ` [Improvements on messages 1/5] rebase: trivial fix of error message Alexander Shopov
2024-02-16 19:05   ` Alex Henrie
2024-02-16 10:15 ` [Improvements on messages 2/5] transport-helper.c: " Alexander Shopov
2024-02-16 10:15 ` [Improvements on messages 3/5] builtin/remote.c: " Alexander Shopov
2024-02-16 10:15 ` [Improvements on messages 4/5] builtin/clone.c: trivial fix of message Alexander Shopov
2024-02-16 10:15 ` [Improvements on messages 5/5] revision.c: trivial fix to message Alexander Shopov
2024-02-16 18:43 ` Junio C Hamano [this message]
2024-03-05 22:05 ` [Improvements on messages 0/5] Disambuiguate between options and commands Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa5o0i71o.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ash@kambanaria.org \
    --cc=git@vger.kernel.org \
    --cc=worldhello.net@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.