All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Alex Henrie <alexhenrie24@gmail.com>,
	git@vger.kernel.org, Jens.Lehmann@web.de
Subject: Re: [PATCH] submodule: deprecate --recurse-submodules=""
Date: Wed, 23 Aug 2023 13:26:09 -0700	[thread overview]
Message-ID: <xmqqa5uhfqu6.fsf@gitster.g> (raw)
In-Reply-To: <ZOZf4/DYOKqQLjR+@nand.local> (Taylor Blau's message of "Wed, 23 Aug 2023 15:37:07 -0400")

Taylor Blau <me@ttaylorr.com> writes:

> So here we'd be doing the equivalent of
>
>     *v = RECURSE_SUBMODULES_OFF;
>
> when trying to parse `--recurse-submodules=""`. Should this advice
> instead say "[...] Use --no-recurse-submodules without an argument,
> which does the same thing"?

Sounds right.  So there is nothing to change here, I guess.

If --recurse-submodules="" does something people do not expect to
happen, an warning might be warranted, but I somehow do not think
that is the case here.  If we are not hurting anybody by accepting
that (possibly unusual) form, I do not think we would want to add an
extra warning, either.

Thanks.

      parent reply	other threads:[~2023-08-23 20:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23  3:28 [PATCH] submodule: deprecate --recurse-submodules="" Alex Henrie
2023-08-23 19:37 ` Taylor Blau
2023-08-23 19:53   ` Alex Henrie
2023-08-23 19:57     ` Taylor Blau
2023-08-23 20:26   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa5uhfqu6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Jens.Lehmann@web.de \
    --cc=alexhenrie24@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.