From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Derrick Stolee <derrickstolee@github.com>,
Phillip Wood via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2] rebase -i: check labels and refs when parsing todo list
Date: Tue, 21 Feb 2023 09:26:01 -0800 [thread overview]
Message-ID: <xmqqa617gcba.fsf@gitster.g> (raw)
In-Reply-To: <09ba35c3-1434-ac23-7ac0-1295dd8aca60@dunelm.org.uk> (Phillip Wood's message of "Tue, 21 Feb 2023 16:29:59 +0000")
Phillip Wood <phillip.wood123@gmail.com> writes:
>> (The "check_refname_format()" line is correct in your patch, but the
>> lines above it are not, for some reason.)
>
> Yes you're right, I'm not sure what happened there. I'll re-roll
Nah, thanks, both. I've applied with reformatting plus Derrick's
Acked-by.
next prev parent reply other threads:[~2023-02-21 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 14:37 [PATCH] rebase -i: check labels and refs when parsing todo list Phillip Wood via GitGitGadget
2023-02-17 15:32 ` Derrick Stolee
2023-02-20 9:24 ` Phillip Wood
2023-02-20 10:03 ` Phillip Wood
2023-02-20 14:19 ` [PATCH v2] " Phillip Wood via GitGitGadget
2023-02-21 14:24 ` Derrick Stolee
2023-02-21 16:29 ` Phillip Wood
2023-02-21 17:26 ` Junio C Hamano [this message]
2023-02-21 17:05 ` [PATCH v3] " Phillip Wood via GitGitGadget
2023-02-21 17:07 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa617gcba.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.