From: Junio C Hamano <gitster@pobox.com>
To: Lars Kellogg-Stedman <lars@oddbit.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] line-range: Fix infinite loop bug with degenerate '$' regex
Date: Sun, 18 Dec 2022 10:33:07 +0900 [thread overview]
Message-ID: <xmqqa63lzeb0.fsf@gitster.g> (raw)
In-Reply-To: <20221214145341.sonppjtshwqoxs6n@oddbit.com> (Lars Kellogg-Stedman's message of "Wed, 14 Dec 2022 09:53:41 -0500")
Lars Kellogg-Stedman <lars@oddbit.com> writes:
>> > @@ -161,6 +160,7 @@ static const char *find_funcname_matching_regexp(xdemitconf_t *xecfg, const char
>> > return bol;
>> > start = eol;
>> > }
>> > + return NULL;
>> > }
>>
>> What is this change about? Isn't the above an endless loop without
>> break, from which the only way for the control to leave it is by
>> returning?
>
> It's not an endless loop without break; this change modified the loop
> condition:
Ah, thanks, that's clear, and sorry for the noise, and thanks.
next prev parent reply other threads:[~2022-12-18 1:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 19:36 [PATCH v2] line-range: Fix infinite loop bug with degenerate regex Lars Kellogg-Stedman
2022-12-07 4:33 ` Eric Sunshine
2022-12-07 4:52 ` Ævar Arnfjörð Bjarmason
2022-12-07 5:29 ` Junio C Hamano
2022-12-07 20:30 ` SZEDER Gábor
2022-12-09 19:16 ` Lars Kellogg-Stedman
2022-12-11 1:53 ` [PATCH v3] line-range: Fix infinite loop bug with degenerate '$' regex Lars Kellogg-Stedman
2022-12-11 3:32 ` Junio C Hamano
2022-12-11 3:34 ` Junio C Hamano
2022-12-14 14:53 ` Lars Kellogg-Stedman
2022-12-18 1:33 ` Junio C Hamano [this message]
2022-12-19 22:48 ` [PATCH v4] line-range: fix infinite loop bug with " Lars Kellogg-Stedman
2022-12-19 22:55 ` Ævar Arnfjörð Bjarmason
2022-12-20 0:00 ` Eric Sunshine
2022-12-20 1:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa63lzeb0.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lars@oddbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.