All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Eugen Konkov <kes-kes@yandex.ru>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: Re* --creation-factor=100 does not show code
Date: Thu, 28 Jul 2022 12:54:55 -0700	[thread overview]
Message-ID: <xmqqa68tau7k.fsf@gitster.g> (raw)
In-Reply-To: <220728.86fsilj9w1.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 28 Jul 2022 21:46:49 +0200")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> On Thu, Jul 28 2022, Junio C Hamano wrote:
>
>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>
>>> That algorithm section also says:
>>>
>>> 	The cost of an edge o--C is the size of C's diff, modified by a
>>> 	fudge factor that should be smaller than 100%.
>>>
>>> Which I find quite confusing to follow, isn't that "fudge factor" the
>>> <percent> (or <factor>) we're accepting with --creation-factor? Doesn't
>>> that also need to be adjusted?
>>>
>>> I still find this documentation quicke lacking, if the default is 60 and
>>> it's not 0..100 what is it then? Are values of 200 sensible in some
>>> cases, 1k? 10k?
>>
>> I think 90% of your responses are better answered not by me.  Feel
>> free to edit "to:" header field when that happens next time ;-)
>
> It's a comment on your patch: If you're updating the <percent> early in
> the doc, shouldn't the proposed update also update the wording later on
> to refer to "factor?"

Per-cent in "100%" is clearly a unit.  I do not know what to use to
replace the mention of "100%" with.  Rewriting it to "... should be
smaller than 100-factor" does not result in a sensible description.

Without other good questions like "if it is not 0..100 then in what
range does the default 60 fall?" answered, I do not think anybody
can come up with a useful replacement to that part.


  reply	other threads:[~2022-07-28 19:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-26 12:54 --creation-factor=100 does not show code Eugen Konkov
2022-07-28 14:59 ` Johannes Schindelin
2022-07-28 16:52   ` Re* " Junio C Hamano
2022-07-28 17:12     ` Ævar Arnfjörð Bjarmason
2022-07-28 17:44       ` Junio C Hamano
2022-07-28 19:46         ` Ævar Arnfjörð Bjarmason
2022-07-28 19:54           ` Junio C Hamano [this message]
2022-07-28 17:49     ` [PATCH] format-patch: clarify --creation-factor=<factor> Eric Sunshine
2022-07-28 20:55       ` Ævar Arnfjörð Bjarmason
2022-07-28 20:59         ` Junio C Hamano
2022-07-28 21:09           ` Eric Sunshine
2022-07-30  0:25             ` Eric Sunshine
2022-07-31 18:56               ` Junio C Hamano
2022-07-29 13:16     ` Re* --creation-factor=100 does not show code Johannes Schindelin
2022-07-29 22:19       ` Junio C Hamano
2022-08-01 23:17         ` Junio C Hamano
2023-04-02 21:55           ` Eugen Konkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa68tau7k.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kes-kes@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.