From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C224BC433F5 for ; Wed, 1 Jun 2022 01:37:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232327AbiFABhH (ORCPT ); Tue, 31 May 2022 21:37:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231584AbiFABhF (ORCPT ); Tue, 31 May 2022 21:37:05 -0400 X-Greylist: delayed 526 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 31 May 2022 18:37:03 PDT Received: from box.jasonyundt.email (box.jasonyundt.email [206.189.182.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 750AD167F1 for ; Tue, 31 May 2022 18:37:03 -0700 (PDT) Received: from authenticated-user (box.jasonyundt.email [206.189.182.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.jasonyundt.email (Postfix) with ESMTPSA id 48BA47E67E; Tue, 31 May 2022 21:28:15 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=jasonyundt.email; s=mail; t=1654046896; bh=fkqPAs5OM1bypga5aM6zQTF2luX5yiPsyRl1CxnWIh8=; h=From:To:Cc:Subject:Date:From; b=OOnWRoEE+DTpcL0fWDqPiD2RQQbFzgM3/P6qILCjCpbrVVLIEAJHEXSSoE7BckNno zc4cXjOkj9bwQF7ET22hvMTDIWBH/PyBal8Vcb7cHdu4lMy5HqDhRHMgV2ZfhYxW3N ABdyh8Yj8wzi3vt17xEfJiAdZcl0XQ6E+Rf7FlOiztMv/ORYGj0KiHq0qNVelxnCSY JgPm6OFGZM7ktCr5tnV2vxaTAZqmAkcLtT+2zzDoqGMPWGPhH1z6u9uNsAfvDmTFEZ 2/+KtzVYvYJyGcHA95jE8w2cftsjuwEjbLnfc08a1zmPS5qzYnQ2daJSvZ0/QRGsE8 50kq4C+9jfL9A== From: Jason Yundt To: git@vger.kernel.org Cc: Jason Yundt , "brian m. carlson" , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= Subject: [PATCH] gitweb: switch to a modern DOCTYPE Date: Tue, 31 May 2022 21:26:47 -0400 Message-Id: <20220601012647.1439480-1-jason@jasonyundt.email> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org According to the HTML Standard FAQ: “What is the DOCTYPE for modern HTML documents? In text/html documents: In documents delivered with an XML media type: no DOCTYPE is required and its use is generally unnecessary. However, you may use one if you want (see the following question). Note that the above is well-formed XML.” Source: [1] Gitweb uses an XHTML 1.0 DOCTYPE: While that DOCTYPE is still valid [2], it has several disadvantages: 1. It’s misleading. The DTD that browsers are supposed to use with that DOCTYPE has nothing to do with XHTML 1.0 and isn’t available at the URL that is given [2]. 2. It’s obsolete. XHTML 1.0 was last revised in 2002 and was superseded in 2018 [3]. 3. It’s unreliable. Gitweb uses   and ⋅ but lets an external file define them. “[…U]using entity references for characters in XML documents is unsafe if they are defined in an external file (except for <, >, &, ", and ').” [4] [1]: [2]: [3]: [4]: Signed-off-by: Jason Yundt --- gitweb/gitweb.perl | 5 ++++- t/t9502-gitweb-standalone-parse-output.sh | 14 ++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 606b50104c..1835487ab2 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4219,7 +4219,10 @@ sub git_header_html { my $mod_perl_version = $ENV{'MOD_PERL'} ? " $ENV{'MOD_PERL'}" : ''; print < - + + +]> diff --git a/t/t9502-gitweb-standalone-parse-output.sh b/t/t9502-gitweb-standalone-parse-output.sh index 8cb582f0e6..81d5625557 100755 --- a/t/t9502-gitweb-standalone-parse-output.sh +++ b/t/t9502-gitweb-standalone-parse-output.sh @@ -220,4 +220,18 @@ test_expect_success 'no http-equiv="content-type" in XHTML' ' no_http_equiv_content_type "p=.git;a=tree" ' +proper_doctype() { + gitweb_run "$@" && + grep -F " X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 001B8C433EF for ; Thu, 2 Jun 2022 00:42:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232814AbiFBAl7 (ORCPT ); Wed, 1 Jun 2022 20:41:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232791AbiFBAl6 (ORCPT ); Wed, 1 Jun 2022 20:41:58 -0400 Received: from ring.crustytoothpaste.net (ring.crustytoothpaste.net [172.105.110.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A1F61737CC for ; Wed, 1 Jun 2022 17:41:56 -0700 (PDT) Received: from camp.crustytoothpaste.net (unknown [IPv6:2001:470:b056:101:a6ae:7d13:8741:9028]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by ring.crustytoothpaste.net (Postfix) with ESMTPSA id 1A4A35A26C; Thu, 2 Jun 2022 00:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=crustytoothpaste.net; s=default; t=1654130516; bh=2CrRjuWqEZ7+ddbpMqzaoWTfC5sD4ty1XUyG3B1NUF4=; h=Date:From:To:Cc:Subject:References:Content-Type: Content-Disposition:In-Reply-To:From:Reply-To:Subject:Date:To:CC: Resent-Date:Resent-From:Resent-To:Resent-Cc:In-Reply-To:References: Content-Type:Content-Disposition; b=uYtHyBeP3FjvKarLHLh2CXmd0q7yb1983/znQm18SZlYmonLj+Z4EYyEvGxULPQk6 LmbRBRmG+1Rh+TLxV1xbTQjOLuFb1F6CD+2aX3ZfeDazfuz4auWcMM6iF4TfDHfREg vF90k9+RnURw8xktRPx196N5xZtObe5BSTIZkqIl23Wa5ZZfsOjlxiwI2FKQWCpQq8 UF1aMfn2atP8kAicbaF5mI3ZZCCx3Mz+lbvPpnm1fc4BLVT6ZE7k6vgZSHxpWHvwwe 3G3RB0vjw5S6W7S4RohL21rgwd+REMt726hBMFTQGDzi58jEogpWIilJ3jtgMcjzS2 sYuCWD1phvFBqKBakaBipqTpNhLDRRdChAEO2c58BDnUPgf7A5SvtQHRC0q6kKChwk RXnCuYVz47H8+tVC0UoOARGVqIqnWTU1kCcTW6YMKDGXqKlPyVQRmieOwx8ZDyZH+u 1Lkv9yYgy83d6k8bkxUpqbeVf+xY7HYsNXjWnWhgZgHMiw6uhyj Date: Thu, 2 Jun 2022 00:41:54 +0000 From: "brian m. carlson" To: Jason Yundt Cc: git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [PATCH] gitweb: switch to a modern DOCTYPE Message-ID: Mail-Followup-To: "brian m. carlson" , Jason Yundt , git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason References: <20220601012647.1439480-1-jason@jasonyundt.email> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RMMu15q2FwuiS3lj" Content-Disposition: inline In-Reply-To: <20220601012647.1439480-1-jason@jasonyundt.email> User-Agent: Mutt/2.2.4 (2022-04-30) Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org --RMMu15q2FwuiS3lj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2022-06-01 at 01:26:47, Jason Yundt wrote: > According to the HTML Standard FAQ: >=20 > =E2=80=9CWhat is the DOCTYPE for modern HTML documents? >=20 > In text/html documents: >=20 > >=20 > In documents delivered with an XML media type: no DOCTYPE is required > and its use is generally unnecessary. However, you may use one if you > want (see the following question). Note that the above is well-formed > XML.=E2=80=9D >=20 > Source: [1] >=20 > Gitweb uses an XHTML 1.0 DOCTYPE: >=20 > "-//W3C//DTD XHTML 1.0 Strict//EN" > "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> >=20 > While that DOCTYPE is still valid [2], it has several disadvantages: >=20 > 1. It=E2=80=99s misleading. The DTD that browsers are supposed to use wit= h that > DOCTYPE has nothing to do with XHTML 1.0 and isn=E2=80=99t available a= t the URL > that is given [2]. While the WHATWG may claim that, an XML parser is absolutely within its rights to refer to and use that DTD, and in fact should do so unless its catalog directs it elsewhere. It may be that some browsers use an internal catalog that refers to a different DTD, however. > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index 606b50104c..1835487ab2 100755 > --- a/gitweb/gitweb.perl > +++ b/gitweb/gitweb.perl > @@ -4219,7 +4219,10 @@ sub git_header_html { > my $mod_perl_version =3D $ENV{'MOD_PERL'} ? " $ENV{'MOD_PERL'}" : ''; > print < > - > + + > + > +]> I think this should be fine. It defines the entities we need and appears to be valid XML. I don't think there should be any problem upgrading to XHTML 5 here. --=20 brian m. carlson (he/him or they/them) Toronto, Ontario, CA --RMMu15q2FwuiS3lj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.3.1 (GNU/Linux) iHUEABYKAB0WIQQILOaKnbxl+4PRw5F8DEliiIeigQUCYpgHUAAKCRB8DEliiIei gQEFAQDxmqKfWUc7Go/oOVpcOnombx2j4rDsUFU+j+/q9m9ahAEAzB0H3oy/xfHk RW5cnHSYq7mJGI0FTzJ+BoAA1jhSUAE= =WtMm -----END PGP SIGNATURE----- --RMMu15q2FwuiS3lj-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26804C43334 for ; Thu, 2 Jun 2022 06:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230403AbiFBGLA (ORCPT ); Thu, 2 Jun 2022 02:11:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbiFBGK7 (ORCPT ); Thu, 2 Jun 2022 02:10:59 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 760111DA0B6 for ; Wed, 1 Jun 2022 23:10:58 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id AED2418B25B; Thu, 2 Jun 2022 02:10:57 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=ht3P2+dVcMl1 Hx3WEAMhf5c9acR6M8Up+7WA1X85BX0=; b=iaYiAI0sqk+/vIgCLTaR2WF61BYB 4KaXNcJ107Gj7Tx+C34I5tftf4BMHPccM+6JxGEzNXeT9ipNxn41FnFtNSbjYZRc LDwOFlQ8KGPheuStowtUhGU3asgcDRPv5KiHX9iC8xz6wjX6CHDWsYuMnmxFzu/O USbjgZeSxs18IZE= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id A4D3418B25A; Thu, 2 Jun 2022 02:10:57 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.92.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 4D41818B255; Thu, 2 Jun 2022 02:10:54 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "brian m. carlson" Cc: Jason Yundt , git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [PATCH] gitweb: switch to a modern DOCTYPE References: <20220601012647.1439480-1-jason@jasonyundt.email> Date: Wed, 01 Jun 2022 23:10:53 -0700 In-Reply-To: (brian m. carlson's message of "Thu, 2 Jun 2022 00:41:54 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: C2A6343E-E23A-11EC-8E7B-CBA7845BAAA9-77302942!pb-smtp21.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "brian m. carlson" writes: >> While that DOCTYPE is still valid [2], it has several disadvantages: >>=20 >> 1. It=E2=80=99s misleading. The DTD that browsers are supposed to use = with that >> DOCTYPE has nothing to do with XHTML 1.0 and isn=E2=80=99t availabl= e at the URL >> that is given [2]. > > While the WHATWG may claim that, an XML parser is absolutely within its > rights to refer to and use that DTD, and in fact should do so unless it= s > catalog directs it elsewhere. It may be that some browsers use an > internal catalog that refers to a different DTD, however. > >> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl >> index 606b50104c..1835487ab2 100755 >> --- a/gitweb/gitweb.perl >> +++ b/gitweb/gitweb.perl >> @@ -4219,7 +4219,10 @@ sub git_header_html { >> my $mod_perl_version =3D $ENV{'MOD_PERL'} ? " $ENV{'MOD_PERL'}" : ''= ; >> print <> >> - >> +> + >> + >> +]> > > I think this should be fine. It defines the entities we need and > appears to be valid XML. I don't think there should be any problem > upgrading to XHTML 5 here. OK, so in short, the patch text looks OK and the proposed log message needs a bit more work? Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4C17C433EF for ; Thu, 2 Jun 2022 07:26:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231715AbiFBH06 (ORCPT ); Thu, 2 Jun 2022 03:26:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231169AbiFBH04 (ORCPT ); Thu, 2 Jun 2022 03:26:56 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB9DC28B5C1 for ; Thu, 2 Jun 2022 00:26:50 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id j7so4162996pjn.4 for ; Thu, 02 Jun 2022 00:26:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=kkYo7Mr+AlZm7eYxF5aHpNZUVxf95ZBUq5Od4TLvSMQ=; b=ppVqZ/9YkQkBvpaTluoc8ihvA9ZR8ZpOPQT8EODbDvdWBxTM3L7pHCa/UfvZ8tYjt2 VyvqwWjB27qsEWg8x3UN3UFCLtqZPfoOIjR/SL0IkGWKU9OIKv197OBKw6bZd0q4+z// xwOfpTJ4UoCqxrlUATLEutZAks98hxTsK93HoldRTpIgKVMlUZcajAMLpLeg1XyTVhmv GkhMCYJeP4hGaQlxeP7QdhxGwLR1FSHgWTc5rIX35xbn+dYg82TvxgLG/AoKT8nEzJep te8QSNLWNsZtLS0A6SXluzgcjustbR4+n0Q2djJ6vp8vBmhpYt9jaSNzjUlwElKbQXDP Nkxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=kkYo7Mr+AlZm7eYxF5aHpNZUVxf95ZBUq5Od4TLvSMQ=; b=l26TkxlhG9w8DQ/cz25yKR7j9S1hKGIHmTQc7FQVeB35xgexZZn7i7HR0oIODbcnyq i1ZSaXCyvrWtU1EnEhVo4VYBJGVwNpHoKfQLsPbc1P+pmB63YUNLQ53O0ezqKHeMW9Oi Lh8+pzeKETS/py5yRZZPtANmzMlwAxFW8JaZ4qKsImyceZISdtbZ1FHIYAgsT2TWOAeG 682wOVVfvsUDVGYRrR02JPZczWV+CUBDaYAxMFqejKINQVcBcaqfbcyUxyMJbJWOFxwP WMiPLmaoMH7RS4o2QLiHgYzxhF5ZnwwdsxjoFoU5PTTde1qKdbhGVeLr2TO28dR2renF nUsg== X-Gm-Message-State: AOAM5310KvxkImZDSgKUqJUD18ViI0CdpQwjvRmLgkBNpKtk7F5saU70 Miluxs+ulET/LzkZzK905y4= X-Google-Smtp-Source: ABdhPJzgNmi8Vrd3Xa/92AwgNqmR3bJV7uOHLlb+Idt9LtIdFGGhekCeawpyFL7JOBFQNqYZxRX41Q== X-Received: by 2002:a17:902:e94e:b0:158:91e6:501 with SMTP id b14-20020a170902e94e00b0015891e60501mr3544967pll.29.1654154810403; Thu, 02 Jun 2022 00:26:50 -0700 (PDT) Received: from [192.168.43.80] (subs03-180-214-233-21.three.co.id. [180.214.233.21]) by smtp.gmail.com with ESMTPSA id i20-20020a635414000000b003f60a8d7dadsm2548473pgb.15.2022.06.02.00.26.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 00:26:49 -0700 (PDT) Message-ID: <530f7bb4-9f12-f681-0188-878054c4efbf@gmail.com> Date: Thu, 2 Jun 2022 14:26:43 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] gitweb: switch to a modern DOCTYPE Content-Language: en-US To: Jason Yundt , git@vger.kernel.org Cc: "brian m. carlson" , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= References: <20220601012647.1439480-1-jason@jasonyundt.email> From: Bagas Sanjaya In-Reply-To: <20220601012647.1439480-1-jason@jasonyundt.email> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 6/1/22 08:26, Jason Yundt wrote: > According to the HTML Standard FAQ: > > “What is the DOCTYPE for modern HTML documents? > > In text/html documents: > > > > In documents delivered with an XML media type: no DOCTYPE is required > and its use is generally unnecessary. However, you may use one if you > want (see the following question). Note that the above is well-formed > XML.” > > Source: [1] > > Gitweb uses an XHTML 1.0 DOCTYPE: > > "-//W3C//DTD XHTML 1.0 Strict//EN" > "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> > > While that DOCTYPE is still valid [2], it has several disadvantages: > > 1. It’s misleading. The DTD that browsers are supposed to use with that > DOCTYPE has nothing to do with XHTML 1.0 and isn’t available at the URL > that is given [2]. > 2. It’s obsolete. XHTML 1.0 was last revised in 2002 and was superseded in > 2018 [3]. > 3. It’s unreliable. Gitweb uses   and ⋅ but lets an external file > define them. “[…U]using entity references for characters in XML documents > is unsafe if they are defined in an external file (except for <, >, > &, ", and ').” [4] > > [1]: > [2]: > [3]: > [4]: > > Signed-off-by: Jason Yundt So basically what this patch does is switch to HTML5, right? That is because I can see DOCTYPE "upgrade" to use "", which is the DOCTYPE for HTML5. If it does, then mention HTML5 in v2. -- An old man doll... just what I always wanted! - Clara From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C4EC43334 for ; Thu, 2 Jun 2022 11:43:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234112AbiFBLn6 (ORCPT ); Thu, 2 Jun 2022 07:43:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233689AbiFBLn4 (ORCPT ); Thu, 2 Jun 2022 07:43:56 -0400 Received: from box.jasonyundt.email (box.jasonyundt.email [206.189.182.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86AD51207CE for ; Thu, 2 Jun 2022 04:43:55 -0700 (PDT) Received: from authenticated-user (box.jasonyundt.email [206.189.182.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.jasonyundt.email (Postfix) with ESMTPSA id AB32D7E67E; Thu, 2 Jun 2022 07:43:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=jasonyundt.email; s=mail; t=1654170232; bh=cbtWKOssdfIScTdSmgdxAxnqGTqwYh6NdmKu70Ku9yI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rn3O1mhBQThxpoSjX0BW3y6xOwXlh9eZ+ek5sqvbSJSo0FV8htdiq3MqDRJEdk6/R C6AXLzdWeRuHYO9V1YMyIgJoAFqm7DKD/lVkQ4IAl73m3nnYueaDC/aTdqpwZAbHKH fZ6Ah28VOsJjCMXdoWACqFJZKlYyf0gbImiAytAd0kpH8LQHGs7RQQXYU78kQOy93a a/lebi7DgByadD/k8hiMVwIZ22mRlDKpdFUhZ6MM2POJP1OMGVY1gMcItPtGbyljrx 9u87ApLEMi53y42jxuWdWeth8rBqObPNHf1tVityv4oa1m2XjvvrT6vp4EEO6whLg3 tGK9q79bitGhg== From: Jason Yundt To: git@vger.kernel.org Cc: Jason Yundt , "brian m. carlson" , =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?= , Bagas Sanjaya Subject: [PATCH v2] gitweb: switch to an XHTML5 DOCTYPE Date: Thu, 2 Jun 2022 07:43:05 -0400 Message-Id: <20220602114305.5915-1-jason@jasonyundt.email> In-Reply-To: <20220601012647.1439480-1-jason@jasonyundt.email> References: <20220601012647.1439480-1-jason@jasonyundt.email> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org According to the HTML Standard FAQ: “What is the DOCTYPE for modern HTML documents? In text/html documents: In documents delivered with an XML media type: no DOCTYPE is required and its use is generally unnecessary. However, you may use one if you want (see the following question). Note that the above is well-formed XML.” Source: [1] Gitweb uses an XHTML 1.0 DOCTYPE: While that DOCTYPE is still valid [2], it has several disadvantages: 1. It’s misleading. If an XML parser uses the DTD at the given link, then the entities   and ⋅ won’t get declared. Instead, the parser has to use a DTD from the HTML Standard that has nothing to do with XHTML 1.0 [2]. 2. It’s obsolete. XHTML 1.0 was last revised in 2002 and was superseded in 2018 [3]. 3. It’s unreliable. Gitweb uses   and ⋅ but lets an external file define them. “[…U]using entity references for characters in XML documents is unsafe if they are defined in an external file (except for <, >, &, ", and ').” [4] [1]: [2]: [3]: [4]: Signed-off-by: Jason Yundt --- Compared to the first version of this patch, this version: 1. makes it clear that XML parsers may used the linked DTD like brian mentioned. 2. mentions HTML5 like Bagas suggested. gitweb/gitweb.perl | 5 ++++- t/t9502-gitweb-standalone-parse-output.sh | 14 ++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 606b50104c..1835487ab2 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4219,7 +4219,10 @@ sub git_header_html { my $mod_perl_version = $ENV{'MOD_PERL'} ? " $ENV{'MOD_PERL'}" : ''; print < - + + +]> diff --git a/t/t9502-gitweb-standalone-parse-output.sh b/t/t9502-gitweb-standalone-parse-output.sh index 8cb582f0e6..81d5625557 100755 --- a/t/t9502-gitweb-standalone-parse-output.sh +++ b/t/t9502-gitweb-standalone-parse-output.sh @@ -220,4 +220,18 @@ test_expect_success 'no http-equiv="content-type" in XHTML' ' no_http_equiv_content_type "p=.git;a=tree" ' +proper_doctype() { + gitweb_run "$@" && + grep -F " X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAFC1C433EF for ; Thu, 2 Jun 2022 18:51:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238258AbiFBSvC (ORCPT ); Thu, 2 Jun 2022 14:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238267AbiFBSvA (ORCPT ); Thu, 2 Jun 2022 14:51:00 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43B961BEA9 for ; Thu, 2 Jun 2022 11:50:59 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 250A512680B; Thu, 2 Jun 2022 14:50:58 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=O5oSlqoPkPjT wSzFIucWRUV2QrUBrxs6uZf8wrJuyco=; b=Qke4MqWv20k0aBT/8EEZqTeQqT/X UQqto9ry+3pwfuhMtfRDVtdAOVtjwaKYbaSieQ5nHD9zD+pNq7VoX9kB4UjS8z50 TCjJW6svfgraaGecpGyD56tnil0yoG6K19rs0jI7s1aMRhxCIlOHlC9xXWs7tiel AkLEkM1Jzta3ErM= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 1832512680A; Thu, 2 Jun 2022 14:50:58 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.92.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 4E882126806; Thu, 2 Jun 2022 14:50:56 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jason Yundt Cc: git@vger.kernel.org, "brian m. carlson" , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Bagas Sanjaya Subject: Re: [PATCH v2] gitweb: switch to an XHTML5 DOCTYPE References: <20220601012647.1439480-1-jason@jasonyundt.email> <20220602114305.5915-1-jason@jasonyundt.email> Date: Thu, 02 Jun 2022 11:50:55 -0700 In-Reply-To: <20220602114305.5915-1-jason@jasonyundt.email> (Jason Yundt's message of "Thu, 2 Jun 2022 07:43:05 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: EF90FC8A-E2A4-11EC-BF41-5E84C8D8090B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jason Yundt writes: > Subject: Re: [PATCH v2] gitweb: switch to an XHTML5 DOCTYPE > > According to the HTML Standard FAQ: > > =E2=80=9CWhat is the DOCTYPE for modern HTML documents? > ... > Compared to the first version of this patch, this version: > 1. makes it clear that XML parsers may used the linked DTD like brian > mentioned. > 2. mentions HTML5 like Bagas suggested. So, is it XHTML5, or HTML5, we want to see on the title? > +proper_doctype() { > + gitweb_run "$@" && > + grep -F " + grep " + grep " +} Hmph, this test does not care what other cruft appears in the file, does not care in what order the three lines that match the patterns appear, and the second and third patterns are even allowed to match the same line. I think that is OK (we do not even mind if the two ENTITY definitions get squashed on the same line). > +test_expect_success 'Proper DOCTYPE with entity declarations' ' > + proper_doctype && > + proper_doctype "p=3D.git" && > + proper_doctype "p=3D.git;a=3Dlog" && > + proper_doctype "p=3D.git;a=3Dtree" > +' As far as I can tell, git_header_html() is the only helper that deals with DOCTYPE, and responses to any request must call git_header_html() to produce the header (or the handler for a particular request type is buggy), but I do not think it is part of this topic's job to ensure that all request handlers call the git_header_html(). So we _could_ do with just a single test without trying different request types if we wanted to, as long as there are existing tests that make sure everybody uses git_header_html(). Was there a particular reason why these four requests were chosen? Do they have different entry points and show the doctype from different codepath? Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BEA4C43334 for ; Thu, 2 Jun 2022 19:52:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238957AbiFBTwh (ORCPT ); Thu, 2 Jun 2022 15:52:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238383AbiFBTwg (ORCPT ); Thu, 2 Jun 2022 15:52:36 -0400 Received: from box.jasonyundt.email (box.jasonyundt.email [206.189.182.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9030B1FCD1 for ; Thu, 2 Jun 2022 12:52:33 -0700 (PDT) Received: from authenticated-user (box.jasonyundt.email [206.189.182.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.jasonyundt.email (Postfix) with ESMTPSA id 938087E744; Thu, 2 Jun 2022 15:51:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=jasonyundt.email; s=mail; t=1654199521; bh=JBDFb8IPeJLyknX11hcmFubTQK+0BhlUgO58b38L5os=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M7Vk6sr7FBfSGur/z3e0Y3rAHA1rST8EmbW3EhzePmaJ/LmepoOg7VVDeZKKHNVd4 hdi4gVgWyOKa0wIt8Eq7LaFwY6l+Xbb0SkkooTLUtNhROuCkWhBwkTBJBhMXzr1JcT vvFL1Av9lQoS2iTKf+WRjr/vr9fde/jUY2o3B1Z+/A5uaHllJFgnpF4pFDIydPVBEt T6UKH3EyR5H1ahXPorJzAoLjYfza5F1DhdkdgsC4wFUDhXuZxTA95KzlyZSHCNMuHl bUqzZ3dBZzT77wHo/nJUSbF1VkGB4Fly9J6kBs7i8MBDMPrLb4H+rLp9oU7o8uNYnp tl0YnILxLU6yw== From: Jason Yundt To: Junio C Hamano Cc: git@vger.kernel.org, "brian m. carlson" , =?ISO-8859-1?Q?=C6var_Arnfj=F6r=F0?= Bjarmason , Bagas Sanjaya Subject: Re: [PATCH v2] gitweb: switch to an XHTML5 DOCTYPE Date: Thu, 02 Jun 2022 15:51:38 -0400 Message-ID: <3180470.44csPzL39Z@jason-lemur-pro> In-Reply-To: References: <20220601012647.1439480-1-jason@jasonyundt.email> <20220602114305.5915-1-jason@jasonyundt.email> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thursday, June 2, 2022 2:50:55 PM EDT Junio C Hamano wrote: > Jason Yundt writes: > > Subject: Re: [PATCH v2] gitweb: switch to an XHTML5 DOCTYPE > >=20 > > According to the HTML Standard FAQ: > > =E2=80=9CWhat is the DOCTYPE for modern HTML documents? > >=20 > > ... > > Compared to the first version of this patch, this version: > > 1. makes it clear that XML parsers may used the linked DTD like brian > >=20 > > mentioned. > >=20 > > 2. mentions HTML5 like Bagas suggested. >=20 > So, is it XHTML5, or HTML5, we want to see on the title? I chose XHTML5 since I didn=E2=80=99t think that it was accurate to say =E2= =80=9CHTML5=20 DOCTYPE=E2=80=9D. The DOCTYPE that this patch uses is valid in the XML synt= ax, but not=20 the HTML syntax. > > +proper_doctype() { > > + gitweb_run "$@" && > > + grep -F " > + grep " > + grep " > +} >=20 > Hmph, this test does not care what other cruft appears in the file, > does not care in what order the three lines that match the patterns > appear, and the second and third patterns are even allowed to match > the same line. I think that is OK (we do not even mind if the two > ENTITY definitions get squashed on the same line). While I was writing this patch, I was thinking something similar. Grep is n= ot=20 a good tool for validating (X)HTML. I thought about creating a test that us= es=20 the Nu Html Checker [1] to validate pages that Gitweb generates, but I deci= ded=20 that that should be the topic of a separate patch. > > +test_expect_success 'Proper DOCTYPE with entity declarations' ' > > + proper_doctype && > > + proper_doctype "p=3D.git" && > > + proper_doctype "p=3D.git;a=3Dlog" && > > + proper_doctype "p=3D.git;a=3Dtree" > > +' >=20 > As far as I can tell, git_header_html() is the only helper that > deals with DOCTYPE, and responses to any request must call > git_header_html() to produce the header (or the handler for a > particular request type is buggy), but I do not think it is part of > this topic's job to ensure that all request handlers call the > git_header_html(). So we _could_ do with just a single test without > trying different request types if we wanted to, as long as there are > existing tests that make sure everybody uses git_header_html(). >=20 > Was there a particular reason why these four requests were chosen? > Do they have different entry points and show the doctype from > different codepath? Not really. When I created a262585d81 (gitweb: remove invalid http- equiv=3D"content-type", 2022-03-08), I chose those requests by running git= =20 instaweb and then clicking on the first four links I saw. For this patch, I= =20 just copied what I had done previously. I don=E2=80=99t know if they use di= fferent=20 codepaths (I don=E2=80=99t understand Perl very well). > Thanks. [1]: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97EC1C43334 for ; Thu, 2 Jun 2022 21:48:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239492AbiFBVsG (ORCPT ); Thu, 2 Jun 2022 17:48:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239489AbiFBVsE (ORCPT ); Thu, 2 Jun 2022 17:48:04 -0400 Received: from ring.crustytoothpaste.net (ring.crustytoothpaste.net [IPv6:2600:3c04::f03c:92ff:fe9e:c6d8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66BE61DA6C for ; Thu, 2 Jun 2022 14:48:03 -0700 (PDT) Received: from camp.crustytoothpaste.net (unknown [IPv6:2001:470:b056:101:a6ae:7d13:8741:9028]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by ring.crustytoothpaste.net (Postfix) with ESMTPSA id 5534A5A26C; Thu, 2 Jun 2022 21:48:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=crustytoothpaste.net; s=default; t=1654206482; bh=eJSjrkyUEOLAXx0w2HZ5YI+X69f2zwMnj/HZtp1s/E4=; h=Date:From:To:Cc:Subject:References:Content-Type: Content-Disposition:In-Reply-To:From:Reply-To:Subject:Date:To:CC: Resent-Date:Resent-From:Resent-To:Resent-Cc:In-Reply-To:References: Content-Type:Content-Disposition; b=syx7MKuFPVoGLajZ/PxaXPF6GW5X9aX73OhriTdN+7h5HdvReXcsLQWs42e9LiW06 W0nVO5CxIj9V9y+lqyJsF/+A1Cpedxp07VqaCO4wx+qm/WgtvoVWcfsl1qN2EzIpVO sfhqEUFVzngA28l1SLOp+jbJebUTdo/r6XvYjLHi+Jj+FrcRmbJCDJfi+MO7BOWBCM +tq/+VbjLYbDdiFDB5wflVI4WTXCEl+vlnP5loKWdKraGC5H1n6cbQVeq0ZMR/gxf1 M4lHxi+MgnzqiKgfN396/eyuowoBODkbzP5EofA389m1YdkS3RFDziPoNDyGlZuNAI wZZwtWIiyD5ZGfh13cM08Lb83B8HHl7WGRqYedkKaVCjdMLgq87HhjnoK3S298/iEG Q15O3K+ob0y+i6Txv4MhetXkixK3H6ZkwzM/98TKb7y97FIMGGHg8mpJLAPdepxfUB 6UJJUVBiisNv+mJ9v8v4OBE7uIrA7lJ3NT3DH/6vjzgJ/YYEUuc Date: Thu, 2 Jun 2022 21:47:59 +0000 From: "brian m. carlson" To: Junio C Hamano Cc: Jason Yundt , git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Bagas Sanjaya Subject: Re: [PATCH v2] gitweb: switch to an XHTML5 DOCTYPE Message-ID: Mail-Followup-To: "brian m. carlson" , Junio C Hamano , Jason Yundt , git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Bagas Sanjaya References: <20220601012647.1439480-1-jason@jasonyundt.email> <20220602114305.5915-1-jason@jasonyundt.email> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3d90jXFZAaahC8W9" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.4 (2022-04-30) Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org --3d90jXFZAaahC8W9 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2022-06-02 at 18:50:55, Junio C Hamano wrote: > Jason Yundt writes: >=20 > > Subject: Re: [PATCH v2] gitweb: switch to an XHTML5 DOCTYPE > > > > According to the HTML Standard FAQ: > > > > =E2=80=9CWhat is the DOCTYPE for modern HTML documents? > > ... > > Compared to the first version of this patch, this version: > > 1. makes it clear that XML parsers may used the linked DTD like brian > > mentioned. > > 2. mentions HTML5 like Bagas suggested. >=20 > So, is it XHTML5, or HTML5, we want to see on the title? It's XHTML 5. Technically, it's the XML syntax of HTML 5, so I don't think we care much about the nit here. > > +proper_doctype() { > > + gitweb_run "$@" && > > + grep -F " > + grep " > + grep " > +} >=20 > Hmph, this test does not care what other cruft appears in the file, > does not care in what order the three lines that match the patterns > appear, and the second and third patterns are even allowed to match > the same line. I think that is OK (we do not even mind if the two > ENTITY definitions get squashed on the same line). Yeah, that should be fine because IIRC this syntax isn't going to be allowed elsewhere in the file. If it did appear elsewhere, then the user would receive an XML parsing error. We _could_ make this check for beginning of file, the XML declaration, and then the specified lines (e.g., with head(1)), but I don't really think that's necessary. We should be fine here for now, and if we decide we need that in the future, we can add it. I'd be happy with this as it stands. --=20 brian m. carlson (he/him or they/them) Toronto, Ontario, CA --3d90jXFZAaahC8W9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.3.1 (GNU/Linux) iHUEABYKAB0WIQQILOaKnbxl+4PRw5F8DEliiIeigQUCYpkwDgAKCRB8DEliiIei gd7tAQCSERmkQOupIuEWzufb5MsG1RqaxulJ25F1boiJ4eRQ9gD/fZSQ7xBMGFkG Sq2FgQR+Py4e0S6QhVY9bs+9csniAgU= =BGN6 -----END PGP SIGNATURE----- --3d90jXFZAaahC8W9-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1117BC43334 for ; Thu, 2 Jun 2022 22:09:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239563AbiFBWJo (ORCPT ); Thu, 2 Jun 2022 18:09:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235682AbiFBWJn (ORCPT ); Thu, 2 Jun 2022 18:09:43 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E9D634643 for ; Thu, 2 Jun 2022 15:09:42 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 54FEA1281BF; Thu, 2 Jun 2022 18:09:41 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=otgaiyp9vJrdaLFQ1RfCyZC9hUGdJQCqc+kRsN 3fqZs=; b=tKyV83eYzmwdqTctVk9eGHWo7bqihNNduXT6x9185ryq8bcn9sVfSJ qLWTXGIrMK03lpKhz5Cul7YYWRhXGzn2djjlnllEP0eeSSQ6z924yAwG6GO5LM2h 7upPYQ/3Hc34iW0HiZetqRM3wkrGUnqWpgJC8hk4ZsbaoixtJy710= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 4B9EA1281BE; Thu, 2 Jun 2022 18:09:41 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.92.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 9CE0C1281BD; Thu, 2 Jun 2022 18:09:40 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "brian m. carlson" Cc: Jason Yundt , git@vger.kernel.org, =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Bagas Sanjaya Subject: Re: [PATCH v2] gitweb: switch to an XHTML5 DOCTYPE References: <20220601012647.1439480-1-jason@jasonyundt.email> <20220602114305.5915-1-jason@jasonyundt.email> Date: Thu, 02 Jun 2022 15:09:39 -0700 In-Reply-To: (brian m. carlson's message of "Thu, 2 Jun 2022 21:47:59 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: B304BC90-E2C0-11EC-A888-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "brian m. carlson" writes: >> > Subject: Re: [PATCH v2] gitweb: switch to an XHTML5 DOCTYPE >> ... >> > 2. mentions HTML5 like Bagas suggested. >> >> So, is it XHTML5, or HTML5, we want to see on the title? > > It's XHTML 5. Technically, it's the XML syntax of HTML 5, so I don't > think we care much about the nit here. I too don't care either way very much. I just noticed the discrepancy between the title and the body, but the mention of HTML5 is after the three-dash lines so nobody gets hurt anyway ;-) > We _could_ make this check for beginning of file, the XML declaration, > and then the specified lines (e.g., with head(1)), but I don't really > think that's necessary. We should be fine here for now, and if we decide > we need that in the future, we can add it. I'd be happy with this as it > stands. Yup, thanks for sanity checking. Will queue.