All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alex Vandiver <alexmv@dropbox.com>
Cc: git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Ben Peart <peartben@gmail.com>
Subject: Re: [PATCH v3 4/4] fsmonitor: Delay updating state until after split index is merged
Date: Tue, 31 Oct 2017 14:24:03 +0900	[thread overview]
Message-ID: <xmqqa80728lo.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: 5cb81a33c31ffa585861f0d3f5a7c7eef5bd8fe0.1509146542.git.alexmv@dropbox.com

Alex Vandiver <alexmv@dropbox.com> writes:

> diff --git a/fsmonitor.c b/fsmonitor.c
> index 4ea44dcc6..417759224 100644
> --- a/fsmonitor.c
> +++ b/fsmonitor.c
> @@ -49,20 +49,7 @@ int read_fsmonitor_extension(struct index_state *istate, const void *data,
>  		ewah_free(fsmonitor_dirty);
>  		return error("failed to parse ewah bitmap reading fsmonitor index extension");
>  	}
> -
> -	if (git_config_get_fsmonitor()) {
> -		/* Mark all entries valid */
> -		for (i = 0; i < istate->cache_nr; i++)
> -			istate->cache[i]->ce_flags |= CE_FSMONITOR_VALID;
> -
> -		/* Mark all previously saved entries as dirty */
> -		ewah_each_bit(fsmonitor_dirty, fsmonitor_ewah_callback, istate);
> -
> -		/* Now mark the untracked cache for fsmonitor usage */
> -		if (istate->untracked)
> -			istate->untracked->use_fsmonitor = 1;
> -	}
> -	ewah_free(fsmonitor_dirty);
> +	istate->fsmonitor_dirty = fsmonitor_dirty;

This makes local variable "int i;" in this function unused and gets
compiler warning.


  reply	other threads:[~2017-10-31  5:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 23:26 [PATCH v3] 0/4 fsmonitor fixes Alex Vandiver
2017-10-27 23:26 ` [PATCH v3 1/4] fsmonitor: Set the PWD to the top of the working tree Alex Vandiver
2017-10-27 23:26   ` [PATCH v3 2/4] fsmonitor: Don't bother pretty-printing JSON from watchman Alex Vandiver
2017-10-27 23:26   ` [PATCH v3 3/4] fsmonitor: Document GIT_TRACE_FSMONITOR Alex Vandiver
2017-10-27 23:26   ` [PATCH v3 4/4] fsmonitor: Delay updating state until after split index is merged Alex Vandiver
2017-10-31  5:24     ` Junio C Hamano [this message]
2017-10-31 17:31       ` Johannes Schindelin
2017-10-31 18:43         ` Alex Vandiver
2017-10-29 12:34 ` [PATCH v3] 0/4 fsmonitor fixes Johannes Schindelin
2017-10-30 12:38 ` Ben Peart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa80728lo.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=alexmv@dropbox.com \
    --cc=git@vger.kernel.org \
    --cc=peartben@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.