From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 0894020756 for ; Fri, 20 Jan 2017 22:31:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752086AbdATWbn (ORCPT ); Fri, 20 Jan 2017 17:31:43 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:63041 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751146AbdATWbn (ORCPT ); Fri, 20 Jan 2017 17:31:43 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id A9B5B62B2C; Fri, 20 Jan 2017 17:31:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=lD74nD287Ru7cvt2+tg/6ZBKut8=; b=OkLHie Cn5Rqu8BI4uz8rpX7/v8Cu7zjW8mcu8eis16J0JHLAinisqXBhK6zZfRkSuqu4vC mOQf0bQfujIiUdWqFZTH45aZf1jyB+1trFo3kUa4Z6jtSm17trjBs12RPD7y1L2R vUz+1q5eISI+zR7yNmGhlgimNWyXzXBXd9Rss= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=PQqLKv4WnEaF0ZZJqPEUGkUf0OsCC0O7 4yAtkV2gm7zbiVED0de2Ocbk4Pd3WPKeurTfS1KVpKx0XAo8Tiz6eWVbaGYAp+hc Sm0l9e/LG5AP1l2DCWpwgHRVjSvhq8ZdqMmns7cLlbJjouHr1N0qFs2pkKZ9a5pw nN+6J4+PawE= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 9425C62B2A; Fri, 20 Jan 2017 17:31:41 -0500 (EST) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id D0CC062B29; Fri, 20 Jan 2017 17:31:40 -0500 (EST) From: Junio C Hamano To: Vladimir Panteleev Cc: git@vger.kernel.org Subject: Re: [PATCH] show-ref: Allow --head to work with --verify References: <20170120155015.4360-1-git@thecybershadow.net> <1bf9a446-0b00-f27a-4625-0bc8c25356fe@gmail.com> Date: Fri, 20 Jan 2017 14:31:39 -0800 In-Reply-To: (Junio C. Hamano's message of "Fri, 20 Jan 2017 14:22:14 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 36AFAF38-DF60-11E6-8322-A7617B1B28F4-77302942!pb-smtp2.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: >> My use case was the following series of steps: >> ... long and readable if a bit too verbose description ... > Your log message for the patch needs to be updated by summarizing > the above better. That raises the number of things to improve in the patch to 3 (so far): * the log message clarification. * the code change I mentioned already to hook into the existing "only read the fully specified ref" part, sharing the actual action (i.e. read_ref() to read it, honor quiet and show it by calling show_one()), instead of adding another clause that does it differently (i.e. you didn't do read_ref/quiet?/show_one) * add a test to make sure that the command also works sensibly when --quiet is used. With all of the above, I think the change makes sense.