From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id D32A71F4F8 for ; Tue, 11 Oct 2016 20:14:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbcJKUOP (ORCPT ); Tue, 11 Oct 2016 16:14:15 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:51202 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751297AbcJKUOO (ORCPT ); Tue, 11 Oct 2016 16:14:14 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id CCE3D4303E; Tue, 11 Oct 2016 16:13:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=sKPF188iGc3d uL9Zq7Vr5l3jnZ8=; b=xhpOWydojT0hB7r3SNigk6m+NTEvdQ2OzLk9UEM+Dayu q23lYP6B0jZJoEvuHb1mhUR29IoNznSspLe7IvcfSWHRN3cu4q6l50LfqHm207ki sIRIihduQpuKW3ICenREAm4Wra3uUjlbomAd0QUfV4YkOd0IXG+B8ljZllDmsjU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=ODicmf Z90vAD/LXt46dzc6Pl8Y/MDEUD8k3kyc6tKmOYe1KVyc7FcXKGmgLDFksPG2xLKu 8inhvLguklkLtZ0UwzdaNLN/2qRn6riedteGVoeBmpixgLm5ybjVxUshfdkv+vv6 zXLDOrvjstqlGW+xxkbW2zTn9WrLHcWHo72jg= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id C507D4303D; Tue, 11 Oct 2016 16:13:39 -0400 (EDT) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 402EC4303C; Tue, 11 Oct 2016 16:13:39 -0400 (EDT) From: Junio C Hamano To: Dennis Kaarsemaker Cc: Mantas =?utf-8?Q?Mikul=C4=97nas?= , git@vger.kernel.org, Brandon Casey Subject: Re: [PATCH] contrib: add credential helper for libsecret References: <20161009123417.147239-1-grawity@gmail.com> <1476198080.3876.8.camel@kaarsemaker.net> <1476216585.3876.10.camel@kaarsemaker.net> Date: Tue, 11 Oct 2016 13:13:37 -0700 In-Reply-To: <1476216585.3876.10.camel@kaarsemaker.net> (Dennis Kaarsemaker's message of "Tue, 11 Oct 2016 22:09:45 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 32BFABDC-8FEF-11E6-A331-5F377B1B28F4-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Dennis Kaarsemaker writes: > On Tue, 2016-10-11 at 22:48 +0300, Mantas Mikul=C4=97nas wrote: >> On 2016-10-11 22:36, Junio C Hamano wrote: >> > Thanks for a review. I'll wait until one of (1) a squashable patch >> > to address the "we do not want unconditional overwrite" issue, (2) a >> > reroll from Mantas to do the same, or (3) a counter-argument from >> > somebody to explain why unconditional overwrite is a good idea here >> > (but not in the original) appears. >>=20 >>=20 >> I overlooked that. I can write a patch, but it shouldn't make any >> difference in practice =E2=80=93 if c->username *was* set, then it wou= ld also >> get added to the search attribute list, therefore the search couldn't >> possibly return any results with a different username anyway. > > Makes sense, so a (3) it is. So... does it mean the gnome-keyring one needs a bugfix?