From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Kevin Daudt <me@ikke.info>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Sep 2016, #05; Mon, 19)
Date: Thu, 22 Sep 2016 15:14:32 -0700 [thread overview]
Message-ID: <xmqqa8ez37lj.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160922064931.ganuwswlnom6nzya@sigill.intra.peff.net> (Jeff King's message of "Thu, 22 Sep 2016 02:49:31 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Sep 21, 2016 at 07:45:50PM +0200, Kevin Daudt wrote:
>
>> On Wed, Sep 21, 2016 at 10:36:57AM -0700, Junio C Hamano wrote:
>> > Kevin Daudt <me@ikke.info> writes:
>> >
>> > > On Mon, Sep 19, 2016 at 04:30:34PM -0700, Junio C Hamano wrote:
>> > >>
>> > >> * kd/mailinfo-quoted-string (2016-09-19) 2 commits
>> > >> - mailinfo: unescape quoted-pair in header fields
>> > >> - t5100-mailinfo: replace common path prefix with variable
>> > >
>> > > Is this good enough, or do you want me to look into the feedback from
>> > > jeff?
>> >
>> > If you are talking about the simplified loop that deliberately sets
>> > a rule that is looser than RFC, yes, I'd like to see you at least
>> > consider the pros and cons of his approach, which looked nicer to my
>> > brief reading of it.
>> >
>> > It is perfectly OK by me (it may not be so if you ask Peff) if you
>> > decide that your version is better after doing so, though.
>>
>> Alright, I'll look into it.
>
> Thanks. I am OK if we do not use my simplified version, but I think
> there were some issues I noted with your last version.
Yup, even some automated tool noticed a new leak ;-)
prev parent reply other threads:[~2016-09-22 22:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 23:30 What's cooking in git.git (Sep 2016, #05; Mon, 19) Junio C Hamano
2016-09-20 21:50 ` Johannes Schindelin
2016-09-21 15:40 ` Junio C Hamano
2016-09-21 18:22 ` Johannes Schindelin
2016-09-21 9:11 ` Duy Nguyen
2016-09-21 15:44 ` Junio C Hamano
2016-09-21 16:26 ` Kevin Daudt
2016-09-21 17:36 ` Junio C Hamano
2016-09-21 17:45 ` Kevin Daudt
2016-09-22 6:49 ` Jeff King
2016-09-22 22:14 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8ez37lj.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ikke.info \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.