From: Junio C Hamano <gitster@pobox.com>
To: Vasily Titskiy <qehgt0@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] Ignore dirty submodule states during stash
Date: Tue, 17 May 2016 10:04:32 -0700 [thread overview]
Message-ID: <xmqqa8joy5sv.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CABSveYgsRU+L5qvY_evwekaRU7-oL_2Mmxt6L1u2dYM7Xfq2rw@mail.gmail.com> (Vasily Titskiy's message of "Tue, 17 May 2016 12:38:19 -0400")
Vasily Titskiy <qehgt0@gmail.com> writes:
> You're right, it's redundant here. Should I resubmit the path without this line?
I wasn't pointing out that it was not needed. I was only asking
what it was meant to do.
If you now think it shouldn't have been there, that merely means
your code was wrong. It does not mean I'm right ;-)
With that line removed, would the patch now becomes right? Are
there other bugs?
next prev parent reply other threads:[~2016-05-17 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 13:16 [PATCH v2] Ignore dirty submodule states during stash Vasily Titskiy
2016-05-17 16:15 ` Junio C Hamano
2016-05-17 16:38 ` Vasily Titskiy
2016-05-17 17:04 ` Junio C Hamano [this message]
2016-05-17 17:12 ` Vasily Titskiy
2016-05-17 16:58 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8joy5sv.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=qehgt0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.