From: Junio C Hamano <gitster@pobox.com>
To: Michael Blume <blume.mike@gmail.com>
Cc: "Matthias Aßhauer" <mha1993@live.de>,
"Git List" <git@vger.kernel.org>,
"Thomas Gummerer" <t.gummerer@gmail.com>,
"Stefan Beller" <sbeller@google.com>
Subject: Re: AW: [PATCH 1/2] stash--helper: implement "git stash--helper"
Date: Mon, 01 Feb 2016 15:40:11 -0800 [thread overview]
Message-ID: <xmqqa8nkt2xw.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAO2U3QhvibfEexCUuDJyj=4P+bebnrQhMaVq3VrgNBLbiTDNaA@mail.gmail.com> (Michael Blume's message of "Mon, 1 Feb 2016 15:36:27 -0800")
Michael Blume <blume.mike@gmail.com> writes:
> Maybe this isn't important given that it looks like the patch is going
> to be rewritten, but I have
>
> stash.c:43:18: warning: incompatible pointer types assigning to 'const
> char *const *' from 'const char *'; take the address with &
> [-Wincompatible-pointer-types]
> write_tree.env = prefix;
The way posted patch tries to use the .env field when using the
run-command API is totally bogus and this compilation error is a
manifestation of that.
But the good news is that this should become irrelevant when the
patch is done by using internal calls ;-).
prev parent reply other threads:[~2016-02-01 23:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 19:38 [PATCH 0/2] Make stash a builtin Matthias Aßhauer
2016-01-28 20:36 ` [PATCH 1/2] stash--helper: implement "git stash--helper" Matthias Asshauer
2016-01-28 20:36 ` [PATCH 2/2] stash: use "stash--helper" Matthias Asshauer
2016-01-28 20:59 ` Stefan Beller
2016-01-28 21:25 ` AW: " Matthias Aßhauer
2016-01-28 21:41 ` Stefan Beller
2016-01-28 23:28 ` Roberto Tyley
2016-01-29 19:37 ` AW: " Matthias Aßhauer
2016-01-29 11:21 ` Thomas Gummerer
2016-01-29 18:34 ` Junio C Hamano
2016-01-28 23:06 ` [PATCH 1/2] stash--helper: implement "git stash--helper" Junio C Hamano
2016-01-29 19:32 ` AW: " Matthias Aßhauer
2016-01-29 19:58 ` Junio C Hamano
2016-02-01 23:36 ` Michael Blume
2016-02-01 23:40 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8nkt2xw.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=blume.mike@gmail.com \
--cc=git@vger.kernel.org \
--cc=mha1993@live.de \
--cc=sbeller@google.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.