From: Junio C Hamano <gitster@pobox.com>
To: larsxschneider@gmail.com
Cc: git@vger.kernel.org, peff@peff.net, jehan@orb.com
Subject: Re: [PATCH] convert: legitimately disable clean/smudge filter with an empty override
Date: Thu, 28 Jan 2016 15:51:44 -0800 [thread overview]
Message-ID: <xmqqa8npl0tr.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1453638170-52041-1-git-send-email-larsxschneider@gmail.com> (larsxschneider@gmail.com's message of "Sun, 24 Jan 2016 13:22:50 +0100")
larsxschneider@gmail.com writes:
> - if (ca.drv) {
> + if (ca.drv && ca.drv->smudge && strlen(ca.drv->smudge)) {
You are not interested in its length, but if it is an empty string
or not, so I'd tweak this like so:
> + if (ca.drv && ca.drv->smudge && *ca.drv->smudge) {
prev parent reply other threads:[~2016-01-28 23:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 12:22 [PATCH] convert: legitimately disable clean/smudge filter with an empty override larsxschneider
2016-01-24 15:06 ` Torsten Bögershausen
2016-01-24 21:35 ` Eric Sunshine
2016-01-27 9:49 ` Lars Schneider
2016-01-27 9:42 ` Lars Schneider
2016-01-24 21:45 ` Jeff King
2016-01-27 9:50 ` Lars Schneider
2016-01-25 1:25 ` Junio C Hamano
2016-01-28 9:27 ` Lars Schneider
2016-01-28 22:06 ` Junio C Hamano
2016-01-28 23:51 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8npl0tr.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jehan@orb.com \
--cc=larsxschneider@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.