From: Junio C Hamano <gitster@pobox.com>
To: Craig Silverstein <csilvers@khanacademy.org>
Cc: git@vger.kernel.org, "Jonathan Nieder" <jrnieder@gmail.com>,
"Nguyễn Thái Ngọc" <pclouds@gmail.com>
Subject: Re: [PATCH] git-new-workdir: support submodules
Date: Sun, 25 Jan 2015 20:05:10 -0800 [thread overview]
Message-ID: <xmqqa916nq4p.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAGXKyzEPWrbRFOhvCBm=2Z50zso85G50z-nLd_wyzyeEADQSmw@mail.gmail.com> (Craig Silverstein's message of "Sat, 24 Jan 2015 17:47:35 -0800")
Craig Silverstein <csilvers@khanacademy.org> writes:
> } Or one new-workdir checkout's branch may check out a top-level
> } project from today while the other one may have a top-level project
> } from two years ago,
>
> This is also true, but just as much a problem with the 'git
> new-workdir' script as it existed before my change. It already
> symlinks the top-level .git/config directory, which lists a remote,
> submodules, and many other things. Does symlinking the config file
> for submodules add any new wrinkles, that symlinking the config file
> for the top-level repository does not?
The update under discussion is labeled as "support submodules";
presumably the only reason that such an update is good is because it
will fix existing problems that makes the use of the script break
when submodules are involved --- submodules are not supported with
the current code, and this patch fixes the code to support it.
But then, you are saying that the update does not fix these existing
issues around submodule support. So...?
next prev parent reply other threads:[~2015-01-26 4:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 21:51 [PATCH] git-new-workdir: support submodules Craig Silverstein
2015-01-24 0:48 ` Craig Silverstein
2015-01-24 1:37 ` Junio C Hamano
2015-01-25 1:47 ` Craig Silverstein
2015-01-26 4:05 ` Junio C Hamano [this message]
2015-01-26 4:57 ` Craig Silverstein
2015-01-26 5:39 ` Junio C Hamano
2015-01-27 17:35 ` Jens Lehmann
2015-01-28 10:50 ` Duy Nguyen
2015-01-28 10:53 ` Duy Nguyen
2015-01-28 20:18 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2014-12-23 2:10 Craig Silverstein
2014-12-23 19:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa916nq4p.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=csilvers@khanacademy.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.