From: Junio C Hamano <gitster@pobox.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Marc Branchaud <marcnarc@xiplink.com>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org,
"Lucas Sandery \[three am design\]" <lucas@threeamdesign.com.au>
Subject: Re: [PATCHv2] gitk: Replace "next" and "prev" buttons with down and up arrows.
Date: Wed, 22 Jan 2014 12:18:27 -0800 [thread overview]
Message-ID: <xmqqa9enydm4.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140122110448.GB7306@iris.ozlabs.ibm.com> (Paul Mackerras's message of "Wed, 22 Jan 2014 22:04:48 +1100")
Paul Mackerras <paulus@samba.org> writes:
> On Tue, Jan 21, 2014 at 10:33:02AM -0500, Marc Branchaud wrote:
>> On 13-12-18 11:04 AM, Marc Branchaud wrote:
>> > Users often find that "next" and "prev" do the opposite of what they
>> > expect. For example, "next" moves to the next match down the list, but
>> > that is almost always backwards in time. Replacing the text with arrows
>> > makes it clear where the buttons will take the user.
>>
>> Any opinions on this, either way?
>>
>> I've grown fond of the down/up arrows. I find them much clearer than the
>> current next/prev buttons.
>>
>> My only niggle about this patch is that the buttons are much smaller,
>> requiring a bit more precision clicking. But the smaller buttons allow more
>> room for other widgets.
>
> I showed it to a few colleagues who use gitk a lot. One was
> indifferent, the others liked it, so I have applied it.
>
> Thanks,
> Paul.
Is this a good time for me to pull from you? I see these on your
'master' branch.
8f86339 gitk: Comply with XDG base directory specification
786f15c gitk: Replace "next" and "prev" buttons with down and up arrows
c61f3a9 gitk: chmod +x po2msg.sh
6c626a0 gitk: Update copyright dates
45f884c gitk: Add Bulgarian translation (304t)
1f3c872 gitk: Fix mistype
Thanks.
next prev parent reply other threads:[~2014-01-22 20:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 2:31 gitk next/prev buttons Lucas Sandery [three am design]
2013-10-02 1:08 ` Lucas Sandery
2013-10-08 17:50 ` Marc Branchaud
2013-10-08 19:36 ` Jonathan Nieder
2013-10-08 20:45 ` Marc Branchaud
2013-12-18 16:04 ` [PATCHv2] gitk: Replace "next" and "prev" buttons with down and up arrows Marc Branchaud
2014-01-21 15:33 ` Marc Branchaud
2014-01-22 11:04 ` Paul Mackerras
2014-01-22 20:18 ` Junio C Hamano [this message]
2014-01-23 11:08 ` Paul Mackerras
2014-01-23 16:51 ` Junio C Hamano
2013-10-08 20:49 ` [PATCH] gitk: Rename "next" and "prev" buttons to "older" and "newer" Marc Branchaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa9enydm4.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=lucas@threeamdesign.com.au \
--cc=marcnarc@xiplink.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.