All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Thomas Rast <tr@thomasrast.ch>, git@vger.kernel.org
Subject: Re: [PATCH] for-each-ref: avoid loading objects to print %(objectname)
Date: Wed, 30 Oct 2013 10:34:40 -0700	[thread overview]
Message-ID: <xmqqa9hqd5n3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131030065016.GB11317@sigill.intra.peff.net> (Jeff King's message of "Wed, 30 Oct 2013 02:50:16 -0400")

Jeff King <peff@peff.net> writes:

> On Sat, Oct 26, 2013 at 10:35:17AM +0200, Thomas Rast wrote:
> ...
>> Can you quote the *?  I may have become somewhat paranoid, but still.
>> This is the first use of the *<field> syntax, and test_atom seems
>> written to correctly quote its arguments, so why risk it? :-)
>
> Yeah, that is a very reasonable suggestion. And the patch is still in
> pu, so it's not too late to squash.
>
> Junio, here is a resend with the asterisks quoted, to replace what's in
> jk/for-each-ref-skip-parsing.  I also double-checked that test_atom
> keeps them properly quoted (it does).

Thanks, both, for being careful.

  reply	other threads:[~2013-10-30 17:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24  8:46 [PATCH] for-each-ref: avoid loading objects to print %(objectname) Jeff King
2013-10-26  8:35 ` Thomas Rast
2013-10-30  6:50   ` Jeff King
2013-10-30 17:34     ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-10-04  7:56 Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa9hqd5n3.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=tr@thomasrast.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.