From: Junio C Hamano <gitster@pobox.com>
To: "Ophir Bleicher via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Ophir Bleicher <ophirble@gmail.com>
Subject: Re: [PATCH] doc: update README file name in my first contribution
Date: Fri, 20 Nov 2026 10:24:51 -0800 [thread overview]
Message-ID: <xmqqbj7jqs24.fsf@gitster.g> (raw)
In-Reply-To: <pull.2495.git.git.1795194253192.gitgitgadget@gmail.com> (Ophir Bleicher via GitGitGadget's message of "Fri, 20 Nov 2026 17:04:13 +0000")
"Ophir Bleicher via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Ophir Bleicher <ophirble@gmail.com>
>
> The translation notice in MyFirstContribution.adoc referenced
"references". We refer to the status quo in the present tense.
> po/README, but the actual file name is po/README.md.
> Changed it to po/README.md.
Have a blank line between the observation and the action. Write the
action part as if you are telling an imaginary person what to do,
i.e.
"Change it to".
> -localizable. Take a look at `po/README` under "Marking strings for translation".
> +localizable. Take a look at `po/README.md` under "Marking strings for translation".
Looking good.
Will queue with commit message tweaks.
THanks.
next prev parent reply other threads:[~2026-11-20 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 17:04 [PATCH] doc: update README file name in my first contribution Ophir Bleicher via GitGitGadget
2026-11-20 18:24 ` Junio C Hamano [this message]
2026-11-20 18:31 ` [PATCH v2] " Ophir Bleicher via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbj7jqs24.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=ophirble@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.