All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: git@vger.kernel.org,  Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH] CodingGuidelines: allow compound literals
Date: Mon, 26 Oct 2026 14:11:08 -0700	[thread overview]
Message-ID: <xmqqbj8gp3pv.fsf@gitster.g> (raw)
In-Reply-To: <a4b382c0373e1b410c4c1ef74b313f86076d48aa.1793024062.git.phillip.wood@dunelm.org.uk> (Phillip Wood's message of "Mon, 26 Oct 2026 14:14:26 +0000")

Phillip Wood <phillip.wood123@gmail.com> writes:

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> Our coding guidelines say that we'll allow compound literals from
> mid 2026 if no problems are reported in relation to the test balloon
> added in 01e49941d6 (reftable/system: provide thin wrapper for tempfile
> subsystem, 2024-11-18). As no such reports have been received, update
> the guidelines to allow this construct.
>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> ---

Yeah, I agree that it is about time to promote this to the accepted
set.

So we do not have test balloon but we know we still cannot use two
constructs from C99 due to MinGW and older IBM xlc?  Perhaps we can
raise test balloons for them by now?

Will merge and mark the topic as ready for 'next'.  Thanks.

> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> index c06f5d3071..23a4d2186a 100644
> --- a/Documentation/CodingGuidelines
> +++ b/Documentation/CodingGuidelines
> @@ -311,13 +311,8 @@ For C programs:
>     . since late 2023 with 8277dbe987 we have been using the bool type
>       from <stdbool.h>.
>  
> -   C99 features we have test balloons for:
> -
> -   . since late 2024 with v2.48.0-rc0~20, we have test balloons for
> -     compound literal syntax, e.g., (struct foo){ .member = value };
> -     our hope is that no platforms we care about have trouble using
> -     them, and officially adopt its wider use in mid 2026.  Do not add
> -     more use of the syntax until that happens.
> +   . since late 2024 with v2.48.0-rc0~20, we have been using compound
> +     literals, e.g., (struct foo){ .member = value };
>  
>     New C99 features that we cannot use yet:

  reply	other threads:[~2026-10-26 21:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 14:14 [PATCH] CodingGuidelines: allow compound literals Phillip Wood
2026-10-26 21:11 ` Junio C Hamano [this message]
2026-10-27  6:36   ` Patrick Steinhardt
2026-10-27 10:49     ` Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbj8gp3pv.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood123@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.